✨ Source Facebook Marketing: improve rate limit error message #37341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sm, translate to AirbyteTracedException
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
|
Looks good, still the examples of some improved error messaging would something be nice to have. |
strosek
reviewed
Apr 16, 2024
airbyte-integrations/connectors/source-facebook-marketing/unit_tests/test_config_migrations.py
Outdated
Show resolved
Hide resolved
strosek
approved these changes
Apr 16, 2024
bazarnov
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Addresses https://github.com/airbytehq/airbyte-internal-issues/issues/7086
How
Commit d3f2db0 fixes various timezone and current working directory issues I had. Setting things to UTC shouldn't be a problem as we set the local time to UTC in the docker container
Commit be7d02d adds the translation of the error to a AirbyteTracedException which will be emitted as-is as part of the error handler. This might not be perfect though as if a rate limit can occur outside of the retry mechanism, the user will still see the old/non-transient error. To mitigate this risk, I've checked the last 5 errors in this table and they all had backoff applied. The ideal solution would be to encapsulate all the Facebook lib stuff but it seems unrealistic as of today given the amount of work it would require. I'll bring the point to the retro so we can discuss about this.
🚨 User Impact 🚨
The user should now see a better looking error when being rate limited.