Skip to content

source-mssql: Allow 60min for MAX_FIRST_RECORD_WAIT_TIME #37326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 15, 2024
Merged

source-mssql: Allow 60min for MAX_FIRST_RECORD_WAIT_TIME #37326

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b3273b3
source-mssql: Allow 60min for MAX_FIRST_RECORD_WAIT_TIME
evantahler Apr 15, 2024
41306ca
useLocalCdk
evantahler Apr 15, 2024
546f0ba
Trigger Build
evantahler Apr 15, 2024
eb78215
Merge branch 'master' into evan/mssql-timeout-1h
evantahler Apr 15, 2024
2bf1ec7
4.0.12
evantahler Apr 15, 2024
d739085
useLocalCdk = false
evantahler Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version=0.30.3
version=0.30.4
2 changes: 1 addition & 1 deletion ...rces/src/main/kotlin/io/airbyte/cdk/integrations/debezium/internals/RecordWaitTimeUtil.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ object RecordWaitTimeUtil {
private val LOGGER: Logger = LoggerFactory.getLogger(RecordWaitTimeUtil::class.java)

val MIN_FIRST_RECORD_WAIT_TIME: Duration = Duration.ofMinutes(2)
val MAX_FIRST_RECORD_WAIT_TIME: Duration = Duration.ofMinutes(40)
val MAX_FIRST_RECORD_WAIT_TIME: Duration = Duration.ofMinutes(60)
val DEFAULT_FIRST_RECORD_WAIT_TIME: Duration = Duration.ofMinutes(5)
val DEFAULT_SUBSEQUENT_RECORD_WAIT_TIME: Duration = Duration.ofMinutes(1)

Expand Down
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-mssql/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ plugins {
}

airbyteJavaConnector {
cdkVersionRequired = '0.30.1'
cdkVersionRequired = '0.30.4'
features = ['db-sources']
useLocalCdk = false
useLocalCdk = true
}

java {
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-mssql/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ data:
connectorSubtype: database
connectorType: source
definitionId: b5ea17b1-f170-46dc-bc31-cc744ca984c1
dockerImageTag: 4.0.11
dockerImageTag: 4.0.12
dockerRepository: airbyte/source-mssql
documentationUrl: https://docs.airbyte.com/integrations/sources/mssql
githubIssueLabel: source-mssql
Expand Down
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-mssql/src/main/resources/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,10 @@
"initial_waiting_seconds": {
"type": "integer",
"title": "Initial Waiting Time in Seconds (Advanced)",
"description": "The amount of time the connector will wait when it launches to determine if there is new data to sync or not. Defaults to 300 seconds. Valid range: 120 seconds to 2400 seconds. Read about <a href=\"https://docs.airbyte.com/integrations/sources/mysql/#change-data-capture-cdc\">initial waiting time</a>.",
"description": "The amount of time the connector will wait when it launches to determine if there is new data to sync or not. Defaults to 300 seconds. Valid range: 120 seconds to 3600 seconds. Read about <a href=\"https://docs.airbyte.com/integrations/sources/mysql/#change-data-capture-cdc\">initial waiting time</a>.",
"default": 300,
"min": 120,
"max": 2400,
"max": 3600,
"order": 3
},
"invalid_cdc_cursor_position_behavior": {
Expand Down
4 changes: 2 additions & 2 deletions ...te-integrations/connectors/source-mssql/src/test-integration/resources/expected_spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,10 @@
"initial_waiting_seconds": {
"type": "integer",
"title": "Initial Waiting Time in Seconds (Advanced)",
"description": "The amount of time the connector will wait when it launches to determine if there is new data to sync or not. Defaults to 300 seconds. Valid range: 120 seconds to 2400 seconds. Read about <a href=\"https://docs.airbyte.com/integrations/sources/mysql/#change-data-capture-cdc\">initial waiting time</a>.",
"description": "The amount of time the connector will wait when it launches to determine if there is new data to sync or not. Defaults to 300 seconds. Valid range: 120 seconds to 3600 seconds. Read about <a href=\"https://docs.airbyte.com/integrations/sources/mysql/#change-data-capture-cdc\">initial waiting time</a>.",
"default": 300,
"min": 120,
"max": 2400,
"max": 3600,
"order": 3
},
"invalid_cdc_cursor_position_behavior": {
Expand Down
217 changes: 154 additions & 63 deletions docs/integrations/sources/mssql.md
View file
Open in desktop

Large diffs are not rendered by default.

Loading