CDK changes to support MSSQL removing normalization #37006
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jbfbell
changed the title
jbfbell
force-pushed
the
jbfbell/refactor_sqloputils_for_airbyte_meta
branch
from
d7d18c2 to
e70a16f
Compare
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
No problems found on commit d7d18c2df538c00a21b98d637ffa3e04eb63053e.
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
jbfbell
force-pushed
the
jbfbell/refactor_sqloputils_for_airbyte_meta
branch
from
e70a16f to
0dbdbb1
Compare
jbfbell
force-pushed
the
jbfbell/refactor_sqloputils_for_airbyte_meta
branch
from
0dbdbb1 to
1f34b9c
Compare
| statement.setTimestamp( | ||
| i, | ||
| Timestamp.from(Instant.ofEpochMilli(message.record!!.emittedAt)) | ||
| if (isDestinationV2) { |
There was a problem hiding this comment.
shall we avoid this implicit TypingDedupingFlag anymore in new code, especially in static method references. probably pass it along with default value as false with multi-arg methods.
| * @param records records to write | ||
| * @throws SQLException exception | ||
| */ | ||
| @Throws(SQLException::class) |
There was a problem hiding this comment.
This is still used in RedshiftSqlOperations v1 insert query call (until everyone adopts the DV2 breaking change that code could get invoked). So keep the @JvmStatic
There was a problem hiding this comment.
Its still static just moved outside the object since it was the only method in the object
There was a problem hiding this comment.
interesting, so kotlin doesn't really have static is what i read. In java ctx is it still invocable as SqlOpUtils.insert.. ?
There was a problem hiding this comment.
Yeah in the stacked PR on top I reference this method via
import static io.airbyte.cdk.integrations.destination.jdbc.SqlOperationsUtilsKt.insertRawRecordsInSingleQuery
|
@jbfbell In Redshift land, when we were switching to Dv2, we ditched this SqlOperationUtils method altogether and have insertRecordv1 and insertRecordv2 as 2 different calls decided in |
A shared method did not account for the
_airbyte_metacolumn and had a static batch size which did not work for MSSQLSummary:
This PR updates the
SqlOperationsUtils.ktto handle the_airbyte_metacolumn for MSSQL, bumps the CDK version, and documents the change in theREADME.md.Key points:
SqlOperationsUtils.ktto handle_airbyte_metacolumn for MSSQL.version.properties.README.mdto document the change.Generated with ❤️ by ellipsis.dev