python: assert actual == expected ordering #36980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @erohmensing and the rest of your teammates on |
octavia-squidington-iii
added
connectors/destination/firestore
connectors/destination/sftp-json
connectors/destination/aws-datalake
connectors/destination/databend
connectors/destination/cumulio
connectors/source/airtable
connectors/source/hubspot
connectors/source/bing-ads
connectors/source/marketo
connectors/source/sentry
connectors/source/amazon-seller-partner
connectors/source/facebook-marketing
connectors/source/github
connectors/source/google-ads
connectors/source/google-search-console
connectors/source/google-sheets
connectors/source/shopify
connectors/source/klaviyo
connectors/source/linkedin-ads
connectors/source/recharge
connectors/source/s3
labels
erohmensing
removed
connectors/source/shopify
connectors/source/klaviyo
connectors/source/linkedin-ads
connectors/source/recharge
connectors/source/s3
connectors/source/salesforce
connectors/source/zendesk-support
connectors/destination/sftp-json
connectors/destination/aws-datalake
connectors/destination/databend
connectors/source/gridly
connectors/source/fastbill
connectors/source/qualaroo
connectors/destination/cumulio
connectors/source/google-drive
labels
brianjlai
approved these changes
Apr 10, 2024
airbyte-integrations/bases/connector-acceptance-test/unit_tests/test_json_schema_helper.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encourage tests being written in the
assert expected == actualorder. Although unittest is not opinionated about this, PyCharm likes to show expected/actual diffs, so it is nice to define it in one direction. We picked the direction that Pycharm uses by default, though if we decided we wanted to go the other direction, this inference is overridable in Pycharm underAdvanced settings > Swap the order of actual and expected assertions in pytest