airbyte-ci: re-enable connector dependency upload on publish #36962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to a02c0f892d98db3373a2210c1be15f9bda867fc3
- Looked at
67lines of code in3files - Took 55 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/publish/pipeline.py:87:
- Assessed confidence :
0% - Comment:
The change in the schema of the dependencies from a dictionary to a list of dictionaries is correctly done. The re-enabling of the upload dependencies step is also correctly done. - Reasoning:
The changes in the PR look good. The change in the schema of the dependencies from a dictionary to a list of dictionaries should not cause any issues. The re-enabling of the upload dependencies step is also correctly done. The version bump in the pyproject.toml file is also correctly done.
Workflow ID: wflow_zi04PJhRVD1JLUPe
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
alafanechere
force-pushed
the
augustin/04-10-airbyte-ci_re-enable_connector_dependency_upload_on_publish
branch
from
a02c0f8 to
8947e6d
Compare
There was a problem hiding this comment.
👍 Looks good to me!
- Performed an incremental review on 8947e6d
- Looked at
75lines of code in3files - Took 2 minutes and 4 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. /airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/publish/pipeline.py:87:
- Assessed confidence :
0% - Comment:
The changes in the PR seem to be in line with the PR description. The dependencies have been changed to an array of objects with package_name and version keys. The version in pyproject.toml has been updated. The connector dependency upload on publish has been re-enabled. There don't seem to be any logical bugs, performance bugs, or security bugs. The code seems to follow best practices. - Reasoning:
The changes in the PR seem to be in line with the PR description. The dependencies have been changed to an array of objects with package_name and version keys. The version in pyproject.toml has been updated. The connector dependency upload on publish has been re-enabled. There don't seem to be any logical bugs, performance bugs, or security bugs. The code seems to follow best practices.
Workflow ID: wflow_nwROAMLevfNXctpq
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
|
/approve-and-merge reason="re-enabling an existing feature, new schema has been validated by the data team" |
|
A crack team of mammals has made a decision. |
octavia-approvington
approved these changes
Apr 11, 2024
octavia-approvington
deleted the
augustin/04-10-airbyte-ci_re-enable_connector_dependency_upload_on_publish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the uploaded file schema.
dependenciesis now an array of objects withpackage_nameandversionkeys. This should make it easier for the data team to ingest this data.This format has been validated by the data team
Summary:
This PR re-enables the upload of connector dependencies on publish with a new schema for
dependenciesand updates the version inpyproject.toml.Key points:
dependenciesto an array of objects withpackage_nameandversionkeys inConnectorDependenciesMetadataclass in/airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/publish/pipeline.py.pyproject.toml.Generated with ❤️ by ellipsis.dev