-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Source Outreach: Migrate Python CDK to Low-code CDK #36954
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Marking PR as ready to merge |
/format-fix
|
24587f9
to
b42468a
Compare
items: | ||
type: | ||
- string | ||
- integer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave one of data type and use transformer to update field data to schema filed type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a mismatch, there are not strings In that, only integers, still a breaking change, but no need to transformer I think, Corrected!
refresh_token: "{{ config['refresh_token'] }}" | ||
token_refresh_endpoint: https://api.outreach.io/oauth/token | ||
grant_type: refresh_token | ||
scopes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete the scopes. Having all scopes is not necessary to sync a specific stream. By default, the availability check should filter the stream if it's not accessible to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scopes are given according to the sandbox credential, which are the scopes to be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All, as I said if user want to sync one stream he no need grant all scopes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
@lazebnyi, Resolved comments and CI green ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@katmarkham could you check breaking changes docs before merge
@katmarkham, Docs checked, Ready for the approval 🙇 |
What
Migrating Source Outreach to Low-Code CDK
Closes airbytehq/airbyte-internal-issues#6916
How
Developed using (Configuration Based Source) low-code CDK
Recommended reading order
spec.yaml
manifest.yaml
schemas/*
Tests
Integration & Acceptance
🚨 User Impact 🚨