Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Outreach: Migrate Python CDK to Low-code CDK #36954

Merged
merged 42 commits into from
May 21, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

Migrating Source Outreach to Low-Code CDK
Closes airbytehq/airbyte-internal-issues#6916

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. spec.yaml
  2. manifest.yaml
  3. schemas/*

Tests

Integration & Acceptance
  • Test successful with incremental syncs

image

🚨 User Impact 🚨

  • Migration to low-code

Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 3:20pm

@btkcodedev
Copy link
Collaborator Author

Inline schema ✅
Poetry lock file ✅
Breaking change referred in metadata ✅
Add migration.md docs file ✅
Docs updated ✅
Formatted ✅

airbyte-ci test - All pass
image

@btkcodedev
Copy link
Collaborator Author

Marking PR as ready to merge

@btkcodedev btkcodedev added the low-code-migration This connector has been migrated to the low-code CDK label Apr 10, 2024
@btkcodedev
Copy link
Collaborator Author

btkcodedev commented May 9, 2024

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (263f800b7dfe93993428f5dccc367618ae86db4b)

items:
type:
- string
- integer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave one of data type and use transformer to update field data to schema filed type

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a mismatch, there are not strings In that, only integers, still a breaking change, but no need to transformer I think, Corrected!

refresh_token: "{{ config['refresh_token'] }}"
token_refresh_endpoint: https://api.outreach.io/oauth/token
grant_type: refresh_token
scopes:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete the scopes. Having all scopes is not necessary to sync a specific stream. By default, the availability check should filter the stream if it's not accessible to the user.

Copy link
Collaborator Author

@btkcodedev btkcodedev May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scopes are given according to the sandbox credential, which are the scopes to be deleted?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@lazebnyi lazebnyi May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All, as I said if user want to sync one stream he no need grant all scopes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@octavia-squidington-iv octavia-squidington-iv requested a review from a team May 16, 2024 03:01
@btkcodedev
Copy link
Collaborator Author

@lazebnyi, Resolved comments and CI green ✅
Ready to merge 🙇

@btkcodedev btkcodedev requested a review from lazebnyi May 16, 2024 03:26
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@katmarkham could you check breaking changes docs before merge

@btkcodedev
Copy link
Collaborator Author

@katmarkham, Docs checked, Ready for the approval 🙇

@lazebnyi lazebnyi merged commit eee94ae into master May 21, 2024
32 checks passed
@lazebnyi lazebnyi deleted the btkcodedev/outreachLowcode branch May 21, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/outreach low-code-migration This connector has been migrated to the low-code CDK team/connectors-python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants