Skip to content

CDK: updated error message for missing streams #36833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Apr 4, 2024

What

When a stream listed in a configured catalog is not found in the source connector, we currently throw a KeyError that defaults to the generic "Something went wrong" external message, and classifies the error as a system error.

This PR addresses #6959 by altering the external messaging to be more specific and correctly listing it as a config error.

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 7:34pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Apr 4, 2024
@ChristoGrab ChristoGrab requested a review from maxi297 April 4, 2024 19:06
@ChristoGrab ChristoGrab marked this pull request as ready for review April 4, 2024 19:07
@ChristoGrab ChristoGrab requested a review from a team April 4, 2024 19:07
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Thanks Christo!

@maxi297
Copy link
Contributor

maxi297 commented Apr 4, 2024

Just a note: don't forget to release source-salesforce with that change so that it takes effect and we can see this reflected in the dashboard

@ChristoGrab ChristoGrab merged commit e74d936 into master Apr 4, 2024
@ChristoGrab ChristoGrab deleted the christo/salesforce-missing-stream-error branch April 4, 2024 19:39
Copy link

sentry-io bot commented Apr 10, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants