Adapt source-mssql to latest Kotlin converted CDK #36772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
rodireich
changed the title
xiaohansong
reviewed
Apr 4, 2024
| @@ -111,7 +111,7 @@ abstract class JdbcDatabase(protected val sourceOperations: JdbcCompatibleSource | |||
| * close the returned stream to release the database connection. Otherwise, there will be a | |||
| * connection leak. | |||
| * | |||
| * @param statementCreator create a [PreparedStatement] from a [Connection]. | |||
| * @paramstatementCreator create a [PreparedStatement] from a [Connection]. | |||
There was a problem hiding this comment.
Formatter did this 🤷♂️
I don't quite know why
xiaohansong
reviewed
Apr 4, 2024
| unsafeQuery( | ||
| { c: Connection -> getPreparedStatement(sql, params, c) }, | ||
| { obj: ResultSet -> obj.metaData } | ||
| { obj: ResultSet -> obj.metaData }, |
There was a problem hiding this comment.
do we need this extra comma?
There was a problem hiding this comment.
I think this is something our formatter does
xiaohansong
approved these changes
Apr 4, 2024
|
/publish-java-cdk dry-run=true
|
|
/publish-java-cdk
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make source-mssql build and test with the latest CDK