Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL to adapt to new cdk #36742

Merged
merged 23 commits into from
Apr 5, 2024
Merged

MySQL to adapt to new cdk #36742

merged 23 commits into from
Apr 5, 2024

Conversation

xiaohansong
Copy link
Contributor

@xiaohansong xiaohansong commented Apr 1, 2024 •
edited
Loading

Most of changes are to add @JvmStatic into CDK code.

Refactored some tests:

  1. we do not allow null namespace anymore thus acceptance test need to be adjusted to that
  2. Some bastion test (SSH tunnel related) need more time to start up
  3. testDB hierarchy was a bit messed up which breaks the special db name test, I cleaned it up in this PR.

@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 4:58pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/source/mysql labels Apr 1, 2024
@xiaohansong xiaohansong requested a review from rodireich April 4, 2024 20:42
@xiaohansong xiaohansong marked this pull request as ready for review April 4, 2024 20:43
@xiaohansong xiaohansong requested review from a team as code owners April 4, 2024 20:43
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 4, 2024
@xiaohansong
Copy link
Contributor Author

xiaohansong commented Apr 5, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/8573086602
✅ Successfully published Java CDK version=0.29.4!

@xiaohansong xiaohansong enabled auto-merge (squash) April 5, 2024 16:57
@xiaohansong xiaohansong merged commit 3c35466 into master Apr 5, 2024
29 checks passed
@xiaohansong xiaohansong deleted the xiaohan/mysql-newcdk branch April 5, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodireich rodireich rodireich approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaohansong @rodireich @octavia-squidington-iii