chore(connector_ops): remove unused scripts #36714
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
@natikgadzhi just to be clear, the reason we're getting rid of these is because these checks are already covered in CAT right? I think we still want to check these things, maybe we're not using the scripts anymore though.
|
@erohmensing in spirit, I agree we probably want to keep these checks. I don't see them as CATs today (but maybe I'm holding them wrong). In But alas, I don't see specific checks for allowedHosts and acceptance tests strictness. I don't understand the latter much, but former seems to be a required option. What do you think we should do? Want me to add a validator that allowedHosts are defined and contain at least one valid host? Should it be this PR or a separate issue? |
|
@natikgadzhi I think there are allowed hosts checks here. I don't think I see anywhere where "x connector must have high strictness level" is implemented - @alafanechere might know more. We might be able to remove this concept in favor of quality level now, if we wanted |
There was a problem hiding this comment.
I believe check-test-strictness-level was used to validate a GA (certified) connector strictness level was set to high.
I'm not sure when / how / why it got removed. But if we really need it it's something I'd definitely check in connectors-qa (as allowed-host).
|
Okay than I'm merging this and taking a note to create a todo for the strictness level check. I don't know if we really believe in it. |
What
Part 1 or https://github.com/airbytehq/airbyte-internal-issues/issues/6897 — removes two unused scripts from
airbyte-ci/connector_ops.