source-greenhouse: ensure inline schemas, updated cdk, poetry (where possible) #36640
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
bleonard
changed the title
| @@ -10,7 +10,7 @@ data: | |||
| connectorSubtype: api | |||
| connectorType: source | |||
| definitionId: 59f1e50a-331f-4f09-b3e8-2e8d4d355f44 | |||
| dockerImageTag: 0.5.1 | |||
| dockerImageTag: 0.5.3 | |||
There was a problem hiding this comment.
is there a reason to bump two versions? Why not go to 0.5.2?
| @@ -83,38 +78,760 @@ definitions: | |||
| class_name: source_greenhouse.components.GreenHouseSlicer | |||
| request_cursor_field: "created_after" | |||
| cursor_field: "applied_at" | |||
| schema_loader: | |||
| type: InlineSchemaLoader | |||
| schema: | |||
There was a problem hiding this comment.
noting the schema definitions will be extracted in their own block the first time the connector is edited with the builder. Not something to block on, but it would be nice to have a script that formats the manifest exactly how the builder likes it.
CC @lmossman
There was a problem hiding this comment.
Happy to work on that for future migrations. Have an example?
There was a problem hiding this comment.
Here's an example: https://gist.github.com/lmossman/1a01b738f2363c896bf557b006839240
| @@ -71,6 +71,8 @@ The Greenhouse connector should not run into Greenhouse API limitations under no | |||
|
|
|||
| | Version | Date | Pull Request | Subject | | |||
| |:--------|:-----------|:---------------------------------------------------------|:----------------------------------------------------------------------------------| | |||
| | 0.5.3 | 2024-04-19 | [36640](https://github.com/airbytehq/airbyte/pull/36640) | Updating to 0.80.0 CDK | | |||
| | 0.5.2 | 2024-04-12 | [36640](https://github.com/airbytehq/airbyte/pull/36640) | schema descriptions | | |||
There was a problem hiding this comment.
nit: do we need to mark that this version isn't actually released?
girarda
deleted the
autopull/schema-descriptions-d2a8da/source-greenhouse
branch
This was created from a set of automated scripts. In each case, not every update was needed for every connector, but overall here is what happened:
auto-schema update -s all description: added descriptions to json and inline schemasconnector-code migrate_to_yaml -c all --type source: migrates json schemas to connectors with a manifestairbyte-ci connectors --name=<all modified connectors from above> migrate_to_base_image: makes sure that each is using a base docker image and updates docsairbyte-ci connectors --name=<all modified connectors from above> migrate-to-poetry: moves connectors not already using poetry to do so and updates documentationairbyte-ci connectors --name=<all modified connectors from above> up_to_date: updated the CDK to newer (0.80.0) versionThe version number and changelogs were also bumped using the
connector-code pullscommand.