-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Hubspot: fix acceptance tests #36541
Source Hubspot: fix acceptance tests #36541
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3a0acc2
to
ccf7ba4
Compare
@@ -10,7 +10,7 @@ data: | |||
connectorSubtype: api | |||
connectorType: source | |||
definitionId: 36c891d9-4bd9-43ac-bad2-10e12756272c | |||
dockerImageTag: 4.0.0 | |||
dockerImageTag: 4.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set this to 4.1.0
due to airbyte-cdk = "^0"
change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disable CAT state validation test due to failing tests. The source have complex conflicts with the latest CDK version, so the new test is temporarily disabled as a workaround. Reduced time of entire sync to avoid timeouts during acceptance test run
I'm curious to dig into this a little bit. Was there a specific version of the CDK was posing a problem? I noticed we are bumping using "^0"
so it sounds like we're not concerned about pinning to a specific version. So presumably poetry lock
was run back when the CDK package was only at 0.73.0
. Can we rerun this command and push the change to the lockfile to the PR?
Which part of the validate_state_messages
was failing? Was it the verifying the recordCounts field was on the state message, or the requirement that every stream emit at least one final state message.
01041ea
to
dd10a53
Compare
5b783d8
to
f915089
Compare
f915089
to
3c4bbb3
Compare
Update: made |
follow up - #36814 |
What
Disable CAT state validation test due to failing tests. The source have complex conflicts with the latest CDK version, so the new test is temporarily disabled as a workaround. Reduced time of entire sync to avoid timeouts during acceptance test run