-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Quickbooks: Update missing stream props and add token refresh udpater #36389
🐛 Source Quickbooks: Update missing stream props and add token refresh udpater #36389
Conversation
Signed-off-by: Henri Blancke <[email protected]>
Signed-off-by: Henri Blancke <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Signed-off-by: Henri Blancke <[email protected]>
Signed-off-by: Henri Blancke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small details. I need to run tests but the change looks good.
airbyte-integrations/connectors/source-quickbooks/source_quickbooks/schemas/bills.json
Show resolved
Hide resolved
...yte-integrations/connectors/source-quickbooks/source_quickbooks/schemas/journal_entries.json
Show resolved
Hide resolved
Signed-off-by: Henri Blancke <[email protected]>
Signed-off-by: Henri Blancke <[email protected]>
Having a hard time running tests to release this change. Hope to get something today/tmw |
@henriblancke I have a quickbooks/invoices stream running daily. My initial pull is successful but the day after it fails. I'm on v3.0.3 running airbyte cloud and my error log is as shown below. Any ideas why this would happen? It almost feels like the refresh token isn't stored or used when the stream loads. I set the token expiry to be 1h from sync (UTC) so the next time it runs (tomorrow) theoretically it should renew the token and sync + store the new refresh token - not too sure what I'm doing wrong. ![]()
|
I am still running into this issue. Can we confirm this is fixed? I am seeing the same exact activity as the above question/problem? |
Changed
bills
,deposits
andjournal_entries
streamsmanifest.json
to include therefresh_token_updater
so new refresh tokens get picked up and stored in config