-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [source-zendesk-support] Fix the fields
data type to include the id
and value
#36388
✨ [source-zendesk-support] Fix the fields
data type to include the id
and value
#36388
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fields
data type to include the id
and value
fields
data type to include the id
and value
@mohamagdy please update the pull request description. Can you link the Zendesk documentation showing the field is valid? Did you run tests confirming the API actually return these values? |
@marcosmarxm thanks for taking a look into this PR. Unfortunately, I can't find the |
@mohamagdy any chance to contact Zendesk to make clear this distinction? Would be quite helpful if you could this :) |
@marcosmarxm I asked Zendesk Customer Service and they pointed me to this page https://support.zendesk.com/hc/en-us/articles/4408886739098-About-ticket-fields saying that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change than ready to go.
...rations/connectors/source-zendesk-support/source_zendesk_support/schemas/shared/tickets.json
Outdated
Show resolved
Hide resolved
…zendesk_support/schemas/shared/tickets.json Co-authored-by: Marcos Marx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
After @marcosmarxm approve can be merged
Set the JSON data type type of
fields
field items in Zendesk Support Tickets API