-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Destination Postgres: airbyte_meta
, CDK upgrade and other fixes
#36363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
airbyte_meta
, CDK upgrade and other fixes
edgao
approved these changes
Mar 21, 2024
.../db-destinations/src/main/java/io/airbyte/cdk/integrations/destination/jdbc/DataAdapter.java
Outdated
Show resolved
Hide resolved
jbfbell
reviewed
Mar 25, 2024
...stinations/src/main/java/io/airbyte/cdk/integrations/destination/jdbc/JdbcSqlOperations.java
Outdated
Show resolved
Hide resolved
4ad3912
to
852724c
Compare
jbfbell
approved these changes
Mar 26, 2024
@@ -1,3 +1,5 @@ | |||
# our testcontainer has issues with too much concurrency. | |||
# 4 threads seems to be the sweet spot. | |||
testExecutionConcurrency=4 | |||
# large sync test takes a while, add 15m timeout. | |||
JunitMethodExecutionTimeout=15 m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't do a blanket execution timeout bump. You can use the @timeout on a single function to do the same thing
nurikk
pushed a commit
to nurikk/airbyte
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/destination/postgres
connectors/destination/postgres-strict-encrypt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.