Skip to content

airbyte-ci: add htmlcov to list of ignored directories for security check #36359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

pnilan
Copy link
Contributor

@pnilan pnilan commented Mar 21, 2024

What

  • Adds htmlcov to list of ignored directories for security check

Why

  • QA checks fail locally if dev has used pytest-cov's coverage html feature to generate html coverage reports as two of the generated files contain http urls.
  • htmlcov is already .gitignored by default in the Airbyte repo so there is little risk it would be cause nightly tests to fail

Screenshot

Screenshot 2024-03-21 at 10 48 22 AM

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 4:53pm

@pnilan pnilan marked this pull request as ready for review March 21, 2024 18:02
@pnilan pnilan requested a review from a team March 21, 2024 18:02
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please bump the version in pyproject.toml and update the changelog in the README?

@pnilan pnilan requested a review from alafanechere March 21, 2024 18:57
@pnilan
Copy link
Contributor Author

pnilan commented Mar 25, 2024

@alafanechere

Can you please bump the version in pyproject.toml and update the changelog in the README?

Updated.

@pnilan pnilan merged commit 0f6214a into master Mar 26, 2024
32 checks passed
@pnilan pnilan deleted the pnilan/airbyte-ci-security-check-htmlcov branch March 26, 2024 17:02
nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants