Skip to content

🎉 Source Google Ads: Add Unrecognized Field description while check_connection #36208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Mar 15, 2024

What

Resolving:

How

  • added try...except to the check_connection method while checking the connection and validating the report structure
  • added a new type of expected error handling QueryErrorEnum.QueryError.UNRECOGNIZED_FIELD to the traced_exception to raise the AirbyteTracebackException instead of the plain error text + added what query and where exactly the problem with the custom query.
  • covered with unit_test case to test_errors.py > test_expected_errors.

The example of the Error tracked:

{
    "type": "LOG",
    "log": {
        "level": "ERROR",
        "message": "The Custom Query: `MY_REPORT` has unrecognized field in the query: 'campaign.NO_EXISTING_FIELD'. Please make sure the field exists or name entered is valid."
    }
}

Is this a Breaking Change?

No.

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 16, 2024 10:50am

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 15, 2024
@bazarnov bazarnov self-assigned this Mar 15, 2024
@bazarnov bazarnov marked this pull request as ready for review March 15, 2024 19:48
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 15, 2024 19:51
@bazarnov bazarnov merged commit 1233f2e into master Mar 16, 2024
30 checks passed
@bazarnov bazarnov deleted the baz/source/google-ads/add-log-message-for-unrecognized-field-in-custom-query branch March 16, 2024 15:43
Copy link

sentry-io bot commented Mar 25, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ google.ads.googleads.errors.GoogleAdsException: (<_InactiveRpcError of RPC that terminated with: /airbyte/integration_code/source_google_ads/goo... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants