Skip to content

convert java CDK core/main to kotlin #36205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 27, 2024
Merged

convert java CDK core/main to kotlin #36205

merged 4 commits into from
Mar 27, 2024

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented Mar 15, 2024 •
edited
Loading

This is an automated translation by intellij

@vercel Vercel
Copy link

vercel bot commented Mar 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 1:20am

This was referenced Mar 15, 2024
Closed
Merged
Merged
@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented Mar 15, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Mar 15, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/test_to_kotlin branch from efebf96 to b00c4bb Compare March 15, 2024 18:32
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch from 7db248e to e1b09cb Compare March 15, 2024 18:32
@stephane-airbyte stephane-airbyte marked this pull request as ready for review March 15, 2024 18:33
@stephane-airbyte stephane-airbyte requested review from a team March 15, 2024 18:33
postamar
postamar approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you useLocalCdk = true in a connector or two and check that everything still works before merging?

@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/test_to_kotlin branch from b00c4bb to 3881d35 Compare March 15, 2024 21:45
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch from e1b09cb to e1e3d3e Compare March 15, 2024 21:45
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/test_to_kotlin branch from 3881d35 to ec45f00 Compare March 15, 2024 21:57
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch from e1e3d3e to c7a25a1 Compare March 15, 2024 21:57
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/test_to_kotlin branch from ec45f00 to 8319b09 Compare March 15, 2024 21:59
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch from c7a25a1 to c12ee2e Compare March 15, 2024 21:59
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/test_to_kotlin branch from 8319b09 to d94cb54 Compare March 20, 2024 04:25
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch from c12ee2e to 1def7c9 Compare March 20, 2024 04:25
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/test_to_kotlin branch from d94cb54 to 28fbff6 Compare March 21, 2024 03:14
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch from 1def7c9 to 8fa3f2c Compare March 21, 2024 03:14
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/test_to_kotlin branch from 28fbff6 to 43a863a Compare March 21, 2024 03:17
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch 2 times, most recently from 45d1a50 to f82cf57 Compare March 21, 2024 05:35
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/test_to_kotlin branch from 43a863a to 2b8d08d Compare March 21, 2024 13:06
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch from f82cf57 to 75fba92 Compare March 21, 2024 13:06
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/test_to_kotlin branch from 2b8d08d to d730400 Compare March 21, 2024 13:57
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch from 75fba92 to 450900f Compare March 21, 2024 13:57
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/test_to_kotlin branch from d730400 to e4467ca Compare March 21, 2024 16:08
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 26, 2024 19:10
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/test_to_kotlin branch from 1f0990d to ff33202 Compare March 26, 2024 22:09
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch from aa76592 to aed8faf Compare March 26, 2024 22:09
@stephane-airbyte stephane-airbyte mentioned this pull request Mar 26, 2024
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/test_to_kotlin branch from ff33202 to c56f5c5 Compare March 26, 2024 22:44
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch from aed8faf to 57215c5 Compare March 26, 2024 22:44
This was referenced Mar 26, 2024
Merged
Merged
Merged
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/test_to_kotlin branch 2 times, most recently from 36e44d0 to fdc92ca Compare March 27, 2024 00:52
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch from 57215c5 to a50de61 Compare March 27, 2024 00:52
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Mar 27, 2024
@stephane-airbyte stephane-airbyte mentioned this pull request Mar 27, 2024
Merged
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Mar 27, 2024
Base automatically changed from stephane/03-15-convert_java_CDK_core/test_to_kotlin to master March 27, 2024 01:10
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch from d5e5ed6 to eeba5cb Compare March 27, 2024 01:10
@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented Mar 27, 2024 •
edited
Loading

Merge activity

  • Mar 26, 9:11 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Mar 26, 9:40 PM EDT: @stephane-airbyte merged this pull request with Graphite.

@stephane-airbyte stephane-airbyte force-pushed the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch from eeba5cb to 021297f Compare March 27, 2024 01:19
@stephane-airbyte stephane-airbyte merged commit cbf8ed3 into master Mar 27, 2024
@stephane-airbyte stephane-airbyte deleted the stephane/03-15-convert_java_CDK_core/main_to_kotlin branch March 27, 2024 01:40
This was referenced Mar 27, 2024
Merged
Merged
nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024
@stephane-airbyte @nurikk-sa
convert java CDK core/main to kotlin (airbytehq#36205)
3ec166e 
This is an automated translation by intellij
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

@gisripa gisripa gisripa approved these changes

@postamar postamar postamar approved these changes

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephane-airbyte @jdpgrailsdev @gisripa @postamar @octavia-squidington-iii