Skip to content

docs: update and remove some bad content #36197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

postamar
Copy link
Contributor

I did a pass on our documentation to check that there wasn't anything in there that could embarrass us by being particularly out of date or misleading.

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 7:27pm

Comment on lines 24 to 28
```bash
git clone [email protected]:{YOUR_USERNAME}/airbyte.git
cd airbyte
./run-ab-platform.sh
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is accurate

Comment on lines 29 to 35
If developing platform:

```bash
git clone [email protected]:{YOUR_USERNAME}/airbyte-platform.git
cd airbyte-platform
docker compose up
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also accurate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page is confusing, but I think partially correct and we should keep something like this around.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see what I can to. I think I might have gotten confused.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check with the platform folks on this - it might still be valid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is for the platform. My bad.

@postamar postamar merged commit f90b5d1 into master Mar 15, 2024
26 checks passed
@postamar postamar deleted the postamar/docs-changes branch March 15, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants