Source Faker: Enable zero-config execution by making 'count' an optional config param #36167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
evantahler
approved these changes
Mar 14, 2024
airbyte-integrations/connectors/source-faker/source_faker/spec.json
Outdated
Show resolved
Hide resolved
|
And another example where the assortment of formatting tools don't agree. Ruff everything |
evantahler
approved these changes
Mar 19, 2024
|
I found the purchase-generating code! https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-faker/source_faker/purchase_generator.py#L51-L66 |
alafanechere
approved these changes
Mar 20, 2024
|
Sorry - missed the above comment. Here is the screenshot:
|
|
I just updated to latest CDK version:
🤞 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use
source-fakerwith zero config. Prior to this change, 'count' was required - even though it was defined with the default of 1,000 records.Drive-by change:
Motivations:
source-fakeroften in PyAirbyte demos and tutorials. For demo and testing purposes, it's helpful to be able to execute the source with zero configuration.Impact