Update CDK for Raw Only Dv2 destinations #36047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 14, 2024
Merged
jbfbell
force-pushed
the
jbfbell/cdk_prep_for_remove_norm
branch
from
a895b20 to
9d9103e
Compare
jbfbell
force-pushed
the
jbfbell/cdk_prep_for_remove_norm
branch
from
9d9103e to
a2c7b0e
Compare
jbfbell
force-pushed
the
jbfbell/cdk_prep_for_remove_norm
branch
from
a2c7b0e to
312d2ad
Compare
| import java.util.* | ||
| import org.apache.commons.lang3.StringUtils | ||
|
|
||
| fun upperQuoted(column: String): String { |
There was a problem hiding this comment.
Why is this outside of the object, and not used in the object (or anywhere in this pr)?
There was a problem hiding this comment.
It's used in the stacked PR on top - it could probably be moved to another package if that makes more sense.
I thought keeping static methods outside of an object was the Kotlin way - do we prefer a different approach
edgao
reviewed
Apr 8, 2024
...n/io/airbyte/cdk/integrations/destination/jdbc/typing_deduping/NoOpJdbcDestinationHandler.kt
Show resolved
Hide resolved
jbfbell
force-pushed
the
jbfbell/cdk_prep_for_remove_norm
branch
from
312d2ad to
645c8e0
Compare
jbfbell
force-pushed
the
jbfbell/cdk_prep_for_remove_norm
branch
from
645c8e0 to
332c782
Compare
edgao
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the CDK to facilitate Destinations which will only have raw tables and not the final table.