gradle: add kotlin support in all projects, warnings as errors #36018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
stephane-airbyte
approved these changes
Mar 13, 2024
|
/approve-and-merge reason="changes to java cdk or connectors are insignificant and don't warrant release" |
|
This code is at peace with itself |
octavia-approvington
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle sometimes whines that the kotlin plugin is being applied separately in the java cdk and in the connectors and that bad things might happen. This PR fixes this to make for a good clean build.
The kotlin compiler is set up slightly differently to before:
-Xjvm-default=allallows compiling concrete methods in kotlin interfaces as default methods in java interfaces; this is useful for java interop.allWarningsAsErrors = truemakes the compilation fail on warnings just like we do for java.This required adding a few annotations in some connectors. None of these changes warrant a CDK or a connector release.