Skip to content

Source Amplitude: unpin CDK #35987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Source Amplitude: unpin CDK #35987

merged 4 commits into from
Mar 12, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Mar 12, 2024

What

Unpinning the CDK for source Amplitude.

How

  • Small update to an integration test.

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 4:27pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 12, 2024
@ChristoGrab ChristoGrab marked this pull request as ready for review March 12, 2024 15:14
@ChristoGrab ChristoGrab requested a review from brianjlai March 12, 2024 15:14
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 12, 2024 15:15
@ChristoGrab ChristoGrab marked this pull request as draft March 12, 2024 15:28
@ChristoGrab ChristoGrab marked this pull request as ready for review March 12, 2024 16:14
@@ -17,7 +17,7 @@ include = "source_amplitude"

[tool.poetry.dependencies]
python = "^3.9,<3.12"
airbyte-cdk = "==0.52.0"
airbyte-cdk = "^0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's way better to have >=0.52.0, but not blocking the update overall.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! I think we're specifically using the ^0 notation to prevent automatic major version updates, but I'll double check with Natik to confirm before unpinning the rest of the connectors 👍

@ChristoGrab ChristoGrab merged commit 5da29ac into master Mar 12, 2024
34 checks passed
@ChristoGrab ChristoGrab deleted the christo/amplitude-cdk branch March 12, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amplitude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants