Skip to content

Destination Redshift: Adopt CDK changes for airbyte_meta #35981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Mar 12, 2024

Plumbing of _airbyte_meta in Raw tables.
Preserve the meta information received from upstream in T+D insert.
Updated tests with new AirbyteRecordMessageMeta format and mixed cases with old syncs and new syncs.

Note that, as part of this change, We have to mute the BaseV1V2 migrator to account for columns with and without meta to avoid a complete rebuild of the raw table. Instead we run another migration with an additive nullable column using ALTER TABLE statement on raw table.

@gisripa gisripa requested review from a team as code owners March 12, 2024 04:50
Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 3:42am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/destination/redshift labels Mar 12, 2024
@gisripa gisripa changed the base branch from master to gireesh/cdk_airbyte_meta March 12, 2024 04:50
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Mar 12, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team March 12, 2024 16:25
@gisripa gisripa force-pushed the gireesh/cdk_airbyte_meta branch from fb9bc6d to 81e28c1 Compare March 12, 2024 16:48
@gisripa gisripa force-pushed the gireesh/redshift_airbyte_meta branch 3 times, most recently from cb2b5cc to 434460e Compare March 12, 2024 20:08
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 12, 2024 20:10
@katmarkham katmarkham removed the request for review from a team March 12, 2024 21:28
@gisripa gisripa force-pushed the gireesh/redshift_airbyte_meta branch from b91227c to e8933ad Compare March 12, 2024 23:21
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 12, 2024 23:22
@gisripa gisripa force-pushed the gireesh/redshift_airbyte_meta branch 2 times, most recently from 5535781 to 9b70387 Compare March 13, 2024 00:31
@gisripa gisripa force-pushed the gireesh/cdk_airbyte_meta branch from fb325ab to c1e2f16 Compare March 13, 2024 02:35
@gisripa gisripa force-pushed the gireesh/redshift_airbyte_meta branch from d4fcf7a to 3f2f246 Compare March 13, 2024 02:41
@gisripa gisripa force-pushed the gireesh/cdk_airbyte_meta branch from c1e2f16 to 6d8d44b Compare March 13, 2024 02:42
@gisripa gisripa force-pushed the gireesh/redshift_airbyte_meta branch from 3f2f246 to 6a9d78f Compare March 13, 2024 02:43
@gisripa gisripa removed request for a team March 13, 2024 02:45
@gisripa gisripa force-pushed the gireesh/redshift_airbyte_meta branch from 6a9d78f to 1b495b4 Compare March 13, 2024 02:46
@gisripa gisripa force-pushed the gireesh/redshift_airbyte_meta branch from 1b495b4 to e2cf3fd Compare March 13, 2024 02:55
@jbfbell jbfbell changed the base branch from gireesh/cdk_airbyte_meta to 03-12-add_tests March 13, 2024 08:47
Copy link
Contributor

jbfbell commented Mar 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@jbfbell jbfbell force-pushed the gireesh/redshift_airbyte_meta branch from 2e8687f to f478f00 Compare March 13, 2024 16:09
@jbfbell jbfbell force-pushed the gireesh/redshift_airbyte_meta branch from f478f00 to 37acfc0 Compare March 13, 2024 17:13
@gisripa gisripa requested a review from a team March 13, 2024 17:13
@jbfbell jbfbell changed the base branch from 03-12-add_tests to gireesh/cdk_airbyte_meta March 13, 2024 17:13
@jbfbell jbfbell force-pushed the gireesh/cdk_airbyte_meta branch from 6d29cad to cb2f682 Compare March 13, 2024 20:05
@jbfbell jbfbell force-pushed the gireesh/redshift_airbyte_meta branch from 37acfc0 to 86a4081 Compare March 13, 2024 20:05
@gisripa gisripa force-pushed the gireesh/cdk_airbyte_meta branch from cb2f682 to 0154bbc Compare March 13, 2024 21:15
@gisripa gisripa force-pushed the gireesh/redshift_airbyte_meta branch from 86a4081 to 1834fb1 Compare March 13, 2024 21:16
Base automatically changed from gireesh/cdk_airbyte_meta to master March 13, 2024 22:29
@gisripa gisripa force-pushed the gireesh/redshift_airbyte_meta branch from 1834fb1 to 434c35c Compare March 13, 2024 22:38
@gisripa gisripa removed the request for review from a team March 13, 2024 22:38
@gisripa gisripa force-pushed the gireesh/redshift_airbyte_meta branch from 4ab6072 to cda0ef9 Compare March 14, 2024 02:21
Summary
=======
Associated changes in fixtures and tests
V1V2 migration to add meta column too.
@jbfbell jbfbell force-pushed the gireesh/redshift_airbyte_meta branch from cda0ef9 to 3dd5a28 Compare March 14, 2024 02:35
@jbfbell jbfbell mentioned this pull request Mar 14, 2024
@gisripa gisripa merged commit 29b8afd into master Mar 14, 2024
29 checks passed
@gisripa gisripa deleted the gireesh/redshift_airbyte_meta branch March 14, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/redshift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants