Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Hubspot: add integration tests #35945

Merged
merged 21 commits into from
Apr 16, 2024
Merged

Source Hubspot: add integration tests #35945

merged 21 commits into from
Apr 16, 2024

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented Mar 11, 2024 •
edited
Loading

What
The issue: https://github.com/airbytehq/airbyte/issues/35188

How
Cover streams defined as empty in acceptance-test-config.yaml with integration tests

@vercel Vercel
Copy link

vercel bot commented Mar 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 5:09pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot labels Mar 11, 2024
@davydov-d davydov-d marked this pull request as draft March 11, 2024 05:37
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 11, 2024 05:37
@davydov-d davydov-d marked this pull request as ready for review March 16, 2024 15:40
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 16, 2024 15:41
@lazebnyi lazebnyi requested a review from maxi297 March 17, 2024 10:41
@davydov-d
Copy link
Collaborator Author

Hey @maxi297 can you please review this PR? Thanks!

maxi297
maxi297 reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the coverage the tests provide. My concerns are only about expressiveness of the tests and how well they document the behavior. As such, I don't think I have hard blockers but I would like to get a feeling or how we can improve them (even if we don't take action). Feel free to challenge them and I'll approve after!

...yte-integrations/connectors/source-hubspot/unit_tests/integrations/test_engagements_calls.py Outdated
assert len(output.errors) == 0

@HttpMocker()
def test_given_missing_scopes_error_when_read_then_hault(self, http_mocker: HttpMocker):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assertion in this test is not so clear to me. What is hault? What are we validating here except that the requests were performed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're validating that the connector stops the sync and does not continue making requests in an infinite loop or something. I've changed the name of the test.

@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 18, 2024 20:03
@davydov-d
Copy link
Collaborator Author

@maxi297 thanks for the review! I've pushed some updates and replied to your comments, please take a look one more time

@lazebnyi lazebnyi requested a review from alafanechere April 9, 2024 14:46
@davydov-d davydov-d requested a review from maxi297 April 10, 2024 17:34
maxi297
maxi297 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for addressing my comments. I think those tests are a great addition to the connector code!

@davydov-d davydov-d merged commit c9f4ad4 into master Apr 16, 2024
30 of 31 checks passed
@davydov-d davydov-d deleted the ddavydov/source-hubspot-integration-tests branch April 16, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxi297 maxi297 maxi297 approved these changes

@bazarnov bazarnov bazarnov approved these changes

@alafanechere alafanechere Awaiting requested review from alafanechere

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davydov-d @maxi297 @bazarnov @octavia-squidington-iii