-
Notifications
You must be signed in to change notification settings - Fork 4.5k
🚨🚨 Source Sendgrid: migrate to low code #35776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
5e1004a
Migrated manifest
bb47c72
Updating unit tests
47b1e84
Updates the spec
64c6c91
Ignore __init__
74ef7b3
Better error message for failure case
1ce980e
Remove manifest schemas
95b4e07
Run formatter
7adc3a1
Not actually being used. In manifest now
323baec
These are not being used because it’s only one stream
f5c18b6
Adds descriptions
4a998a4
Switch to integers
d3de4eb
Stream code no longer exists
91090d1
Use host == base_url
af3704d
Merge branch 'master' into sendgrid_yaml
bleonard ca5df43
Config migration
0b24d9e
Merge branch 'master' into sendgrid_yaml
bleonard 358df63
Change to 0.50 version
8d12dbc
Fix formatting
9a8c625
Note breaking change
6119c9b
Fix unit tests with the new base url
4865db3
Go back to 0.65
5c119de
New incremental stream
c961c3f
Update expected records
6d40d29
Upgrade to newest CDK
a2b5d13
format
9afc848
Merge branch 'master' into sendgrid_yaml
bleonard 2917195
Migration guide
0839111
typo
76b77f5
changelog
a8c737c
Update config
7abae02
Use this config
f938e72
Leave the old values in for backwards migration
3c75a44
Bump airbyte-cdk
c0a246a
Merge branch 'master' into sendgrid_yaml
bleonard 0a5176e
Handle epoch time input format
a1cfeeb
Merge branch 'master' into sendgrid_yaml
2549a46
Resolve conflicts
dd85496
Updated per comments
0e45486
Update docs
9ed7141
Align schemas
640ff8d
Delete step and cursor_granularity params from incremental sync
91ba85f
Merge branch 'master' into sendgrid_yaml
7d210eb
Merge branch 'master' into sendgrid_yaml
erohmensing 547cc4b
Update primary keys
cf1ed6e
Bump CDK version
3ce907a
Update docs
82f2d76
Merge branch 'master' into sendgrid_yaml
1f9d30b
Merge branch 'master' into sendgrid_yaml
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
[run] | ||
omit = | ||
source_sendgrid/run.py | ||
source_sendgrid/__init__.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
airbyte-integrations/connectors/source-sendgrid/integration_tests/invalid_api_key.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"apikey": "wrong.api.key123" | ||
"api_key": "wrong.api.key123" | ||
} |
4 changes: 2 additions & 2 deletions
4
airbyte-integrations/connectors/source-sendgrid/integration_tests/invalid_time.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
{ | ||
"apikey": "apikey", | ||
"start_time": "some erroneous input" | ||
"api_key": "apikey", | ||
"start_date": "some erroneous input" | ||
bleonard marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
166 changes: 64 additions & 102 deletions
166
airbyte-integrations/connectors/source-sendgrid/poetry.lock
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just merged from master, or is this new?