Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destinatoin snowflake: Add config option to enable time travel #35754

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Mar 1, 2024

closes #21879

... also sets the retention period on the final tables, where previously we weren't. I could see an argument that - since we've been using the default (1 day) since dv2 release, that we should actually default to 1 day everywhere? but either way, wanted to get the bones of the PR out for review + trigger CI.

@edgao edgao requested a review from a team as a code owner March 1, 2024 16:46
Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 7:41pm

@evantahler
Copy link
Contributor

I would vote for 1-day retention on all tables as the default, but that's a soft prefrence.

@edgao
Copy link
Contributor Author

edgao commented Mar 1, 2024

sold on 1 day by default. I don't particularly want to write a migration for alter table blah set data_retention_days = <new value> though - i.e. existing raw tables will continue to use 0-day retention. (mostly b/c it's just extra complexity to implement. We never automatically drop/recreate raw tables, so users are free to manually do that alter table if they want)

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 8, 2024
@edgao edgao enabled auto-merge (squash) April 8, 2024 16:57
@edgao edgao merged commit 4fc7f1a into master Apr 10, 2024
28 checks passed
@edgao edgao deleted the edgao/snowflake/configurable_retention_period branch April 10, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/snowflake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destination Snowflake: allow configuration of data_retention_time_in_days so we can set values greater than 0
4 participants