Skip to content

Fix error message for saved offset not valid. #35675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

akashkulk
Copy link
Contributor

@akashkulk akashkulk commented Feb 27, 2024

s/reduce sync frequency/increase sync frequency

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 9:22pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 27, 2024
@akashkulk akashkulk marked this pull request as ready for review February 27, 2024 21:18
@akashkulk akashkulk requested a review from a team as a code owner February 27, 2024 21:18
@akashkulk akashkulk enabled auto-merge (squash) February 27, 2024 21:19
@akashkulk akashkulk merged commit ae39cbe into master Feb 27, 2024
@akashkulk akashkulk deleted the akash/change-error-msg branch February 27, 2024 21:54
@@ -119,7 +119,7 @@ public List<AutoCloseableIterator<AirbyteMessage>> createCdcIterators(
AirbyteTraceMessageUtility.emitAnalyticsTrace(cdcCursorInvalidMessage());
if (config.shouldFailSyncOnInvalidCursor()) {
throw new ConfigErrorException(
"Saved offset is not valid. Please reset the connection, and then increase oplog retention or reduce sync frequency to prevent his from happening in the future. See https://docs.airbyte.com/integrations/sources/mongodb-v2#mongodb-oplog-and-change-streams for more details");
"Saved offset is not valid. Please reset the connection, and then increase oplog retention and/or increase sync frequency to prevent his from happening in the future. See https://docs.airbyte.com/integrations/sources/mongodb-v2#mongodb-oplog-and-change-streams for more details");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: I have a bunch of tables which are rarely used but we use Airbyte to sync them.
By definition, these tables will have an outdated oplog resume token that would not exist.
Shouldnt the expected behaviour be trigerring a full rebuild in that case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An oplog resume token being rotated out can lead to data loss since deletes aren't properly captured. In addition, it can lead to higher cloud costs due to consumption of credits.

If you do want to rebuild you can :

  1. Move the tables that are rarely used to a new connection.
  2. In that connection, you change the invalid cdc cursor behavior to "Re-sync Data". This will change it to the previous behavior of rebuilding

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @akashkulk :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition was in the source and not in the connection 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants