Skip to content

doc: remove Node requirements on config based getting started tutorial #35436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024
Merged

doc: remove Node requirements on config based getting started tutorial #35436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/connector-development/config-based/tutorial/0-getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ This can be done by signing up for the Free tier plan on [Exchange Rates Data AP
- Python >= 3.9
- [Poetry](https://python-poetry.org/)
- Docker must be running
- NodeJS
- [`airbyte-ci`](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md#L1) CLI

## Next Steps
Expand Down
10 changes: 5 additions & 5 deletions docs/connector-development/tutorials/cdk-speedrun.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,17 +117,17 @@ cd ..
mkdir sample_files
echo '{"pokemon_name": "pikachu"}' > sample_files/config.json
echo '{"pokemon_name": "chikapu"}' > sample_files/invalid_config.json
python main.py check --config sample_files/config.json
python main.py check --config sample_files/invalid_config.json
poetry run source-python-http-example check --config sample_files/config.json
poetry run source-python-http-example check --config sample_files/invalid_config.json
```

Expected output:

```text
> python main.py check --config sample_files/config.json
```bash
> poetry run source-python-http-example check --config sample_files/config.json
{"type": "CONNECTION_STATUS", "connectionStatus": {"status": "SUCCEEDED"}}

> python main.py check --config sample_files/invalid_config.json
> poetry run source-python-http-example check --config sample_files/invalid_config.json
{"type": "CONNECTION_STATUS", "connectionStatus": {"status": "FAILED", "message": "'Input Pokemon chikapu is invalid. Please check your spelling our input a valid Pokemon.'"}}
```

Expand Down