-
Notifications
You must be signed in to change notification settings - Fork 4.5k
✨ [source-google-sheets] add row_batch_size as an input parameter with higher increase #35404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
f81e338
b5c838f
9ca93fa
d14709c
e14fba9
0fcdd91
fa10827
982189d
5203108
60b1b94
ef8b350
f5dce87
e256a60
73a7640
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,12 @@ connectionSpecification: | |
- credentials | ||
additionalProperties: true | ||
properties: | ||
batch_size: | ||
type: integer | ||
title: Row Batch Size | ||
description: >- | ||
An integer representing row batch size with each sent request to Google Sheets API. Defaults to 200. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tautvydas-v lgtm, could you please add more detailed description here and in .md file for Row Batch Size. Info about what impact this value have on rate limits, sycn etc, and how to define most suitable value for users. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added in more documentation |
||
default: 200 | ||
spreadsheet_id: | ||
type: string | ||
title: Spreadsheet Link | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for old configs without batch_size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed