Skip to content

destination-e2e-test,dev-null: use CDK 0.20.6 #35278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2024
Merged

destination-e2e-test,dev-null: use CDK 0.20.6 #35278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55731c4
destination-e2e-test,dev-null: use CDK 0.20.6
Feb 14, 2024
3f5ec39
bump versions and update changelog
Feb 14, 2024
8c70566
skip integration test case
Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions airbyte-integrations/connectors/destination-dev-null/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,18 @@
plugins {
id 'application'
id 'airbyte-java-connector'
}

airbyteJavaConnector {
cdkVersionRequired = '0.2.0'
cdkVersionRequired = '0.20.6'
features = ['db-destinations']
useLocalCdk = false
}

//remove once upgrading the CDK version to 0.4.x or later
java {
compileJava {
options.compilerArgs.remove("-Werror")
}
}

airbyteJavaConnector.addCdkDependencies()

application {
mainClass = 'io.airbyte.integrations.destination.dev_null.DevNullDestination'
applicationDefaultJvmArgs = ['-XX:+ExitOnOutOfMemoryError', '-XX:MaxRAMPercentage=75.0']
}

dependencies {
implementation project(':airbyte-integrations:connectors:destination-e2e-test')

integrationTestJavaImplementation project(':airbyte-integrations:connectors:destination-dev-null')
}
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-dev-null/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ data:
connectorSubtype: file
connectorType: destination
definitionId: a7bcc9d8-13b3-4e49-b80d-d020b90045e3
dockerImageTag: 0.3.0
dockerImageTag: 0.3.1
dockerRepository: airbyte/destination-dev-null
githubIssueLabel: destination-dev-null
icon: airbyte.svg
Expand Down
5 changes: 5 additions & 0 deletions ...n/java/io/airbyte/integrations/destination/dev_null/DevNullDestinationAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,9 @@ protected void assertSameMessages(final List<AirbyteMessage> expected,
assertEquals(0, actual.size());
}

@Override
public void testSyncNotFailsWithNewFields() {
// Skip because `retrieveRecords` returns an empty list at all times.
}

}
13 changes: 2 additions & 11 deletions airbyte-integrations/connectors/destination-e2e-test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,16 @@
plugins {
id 'application'
id 'airbyte-java-connector'
}

airbyteJavaConnector {
cdkVersionRequired = '0.2.0'
cdkVersionRequired = '0.20.6'
features = ['db-destinations']
useLocalCdk = false
}

//remove once upgrading the CDK version to 0.4.x or later
java {
compileJava {
options.compilerArgs.remove("-Werror")
}
}

airbyteJavaConnector.addCdkDependencies()

application {
mainClass = 'io.airbyte.integrations.destination.e2e_test.TestingDestinations'
applicationDefaultJvmArgs = ['-XX:+ExitOnOutOfMemoryError', '-XX:MaxRAMPercentage=75.0']
}

dependencies {
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-e2e-test/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ data:
connectorSubtype: unknown
connectorType: destination
definitionId: 2eb65e87-983a-4fd7-b3e3-9d9dc6eb8537
dockerImageTag: 0.3.0
dockerImageTag: 0.3.1
dockerRepository: airbyte/destination-e2e-test
githubIssueLabel: destination-e2e-test
icon: airbyte.svg
Expand Down
5 changes: 5 additions & 0 deletions .../io/airbyte/integrations/destination/e2e_test/TestingSilentDestinationAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,9 @@ protected void assertSameMessages(final List<AirbyteMessage> expected,
assertEquals(0, actual.size());
}

@Override
public void testSyncNotFailsWithNewFields() {
// Skip because `retrieveRecords` returns an empty list at all times.
}

}
1 change: 1 addition & 0 deletions docs/integrations/destinations/e2e-test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ The OSS and Cloud variants have the same version number starting from version `0

| Version | Date | Pull Request | Subject |
|:--------|:-----------| :------------------------------------------------------- |:----------------------------------------------------------|
| 0.3.1 | 2024-02-14 | [35278](https://github.com/airbytehq/airbyte/pull/35278) | Adopt CDK 0.20.6 |
| 0.3.0 | 2023-05-08 | [25776](https://github.com/airbytehq/airbyte/pull/25776) | Standardize spec and change property field to non-keyword |
| 0.2.4 | 2022-06-17 | [13864](https://github.com/airbytehq/airbyte/pull/13864) | Updated stacktrace format for any trace message errors |
| 0.2.3 | 2022-02-14 | [10256](https://github.com/airbytehq/airbyte/pull/10256) | Add `-XX:+ExitOnOutOfMemoryError` JVM option |
Expand Down