Source Faker: Declare primary keys

[aaronsteers]

This declares the 'id' columns to be primary keys on all three streams.

This was driven by a need to leverage this test connector in:

• AirbyteLib: Support write strategies: 'merge' and 'auto' #34592

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Jan 30, 2024 6:56am

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[aaronsteers]

@evantahler - You are the latest contributor to this connector and I wanted to ask your approval, in case there are any tests that would be negatively impacted by this change. If this does create a problem, I may need to find or build a different test connector.

[flash1293]

LGTM

[evantahler]

Totally fine with this change. But, connectors are allowed to have user-defined PKs. Is there a use case where that doesn't work in airbyte-lib?

[aaronsteers]

Totally fine with this change. But, connectors are allowed to have user-defined PKs. Is there a use case where that doesn't work in airbyte-lib?

Thanks, @evantahler ! I did consider that... it's just not functionality we've exposed in the API or scoped out as of yet. As of now, AirbyteLib will just use whatever primary gets the source defines (if any).