Skip to content

Source S3: updates for compatibility with the concurrent CDK #34591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2024
Merged

Source S3: updates for compatibility with the concurrent CDK #34591

merged 1 commit into from
Feb 5, 2024

Conversation

clnoll
Copy link
Contributor

@clnoll clnoll commented Jan 28, 2024

Add catalog, config, and state to the args sent to the source, for compatibility with the concurrent CDK.

Depends on #34411.

@clnoll clnoll requested a review from a team January 28, 2024 21:39
@vercel Vercel
Copy link

vercel bot commented Jan 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 2:36pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/source/s3 labels Jan 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2024 •
edited by clnoll
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 28, 2024 21:41
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 57bced5 to 98b7dd8 Compare January 29, 2024 01:32
@clnoll clnoll requested review from girarda and maxi297 January 29, 2024 01:40
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 98b7dd8 to 7d7fd18 Compare January 29, 2024 02:50
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 29, 2024
@clnoll clnoll changed the base branch from master to fcdk-with-ccdk January 29, 2024 02:51
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 7d7fd18 to 532cc10 Compare January 29, 2024 02:53
@clnoll clnoll changed the base branch from fcdk-with-ccdk to master January 29, 2024 02:54
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Jan 29, 2024
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 532cc10 to 2ce72b5 Compare January 30, 2024 00:53
girarda
girarda approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! :shipit:

airbyte-integrations/connectors/source-s3/source_s3/v4/source.py
@@ -21,14 +21,17 @@


class SourceS3(FileBasedSource):
def read_config(self, config_path: str) -> Mapping[str, Any]:
_concurrency_level = DEFAULT_CONCURRENCY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there value in allowing the user to configure the concurrency level?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to allow each source to turn on concurrency intentionally, instead of accidentally deploying it when the next version of the connector is deployed.

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jan 30, 2024
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 17a7c5e to 2b188f8 Compare January 30, 2024 01:37
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 2b188f8 to ed7947a Compare January 30, 2024 02:05
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Jan 30, 2024
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from ed7947a to 59fb0e2 Compare January 30, 2024 03:53
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jan 30, 2024
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 59fb0e2 to a7e2ee2 Compare January 30, 2024 04:33
maxi297
maxi297 reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CATs will probably fail until #34605 is available. It is currently blocked by #34653. I'll release as soon as it is approved

@clnoll clnoll requested a review from a team January 30, 2024 15:42
@clnoll clnoll requested a review from a team as a code owner January 30, 2024 15:42
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 90fe619 to 16db127 Compare January 30, 2024 16:14
@octavia-squidington-iii octavia-squidington-iii removed CDK Connector Development Kit area/documentation Improvements or additions to documentation labels Jan 30, 2024
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 16db127 to 87d61e3 Compare January 30, 2024 16:19
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 30, 2024
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 87d61e3 to 776bf56 Compare January 30, 2024 16:21
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 776bf56 to 40ef2da Compare January 30, 2024 20:26
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 40ef2da to 48b8f83 Compare January 31, 2024 13:49
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from df35244 to 998f28a Compare February 1, 2024 17:56
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 998f28a to c4ae774 Compare February 1, 2024 19:37
@clnoll clnoll force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from c4ae774 to 958e659 Compare February 5, 2024 14:34
@clnoll clnoll merged commit 53d71f9 into master Feb 5, 2024
@clnoll clnoll deleted the source-s3-fcdk-with-ccdk-full-refresh branch February 5, 2024 15:01
@pedroslopez pedroslopez mentioned this pull request Feb 6, 2024
Merged
xiaohansong pushed a commit that referenced this pull request Feb 13, 2024
@clnoll @xiaohansong
Source S3: updates for compatibility with the concurrent CDK (#34591)
dfe4431
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@clnoll @jatinyadav-cc
Source S3: updates for compatibility with the concurrent CDK (airbyte…
bcce784 
…hq#34591)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@clnoll @jatinyadav-cc
Source S3: updates for compatibility with the concurrent CDK (airbyte…
c3ac71e 
…hq#34591)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@clnoll @jatinyadav-cc
Source S3: updates for compatibility with the concurrent CDK (airbyte…
11f96be 
…hq#34591)
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@clnoll @xiaohansong
Source S3: updates for compatibility with the concurrent CDK (#34591)
7675657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxi297 maxi297 maxi297 left review comments

@girarda girarda girarda approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/s3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clnoll @girarda @maxi297 @octavia-squidington-iii