airbyte-lib: Add publish action #34486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
…ing' into flash1293/airbyte-lib-publish2
added 4 commits
January 25, 2024 10:00
aaronsteers
approved these changes
Jan 25, 2024
Comment on lines
+12
to
+17
| ## Release | ||
|
|
||
| * In your PR: | ||
| * Bump the version in `pyproject.toml` | ||
| * Add a changelog entry to the table below | ||
| * Once the PR is merged, go to Github and trigger the `Publish AirbyteLib Manually` workflow. This will publish the new version to PyPI. |
There was a problem hiding this comment.
Do we get CI checks for missing changelog entries and/or unbumped versions?
It would be great if we could piggy-back on existing rails, if that's possible.
There was a problem hiding this comment.
There's not really good existing guardrails as all places kind of do their own thing (connectors, airbyte-cdk). However, I added a basic check that a changelog entry is set for the current version.
I kept this simple deliberately so we have control over the publishing process in the first messy phase. We can add some automation later on if it makes sense (like auto-publishing as soon as the version changes on merge to master).
added 2 commits
January 26, 2024 09:57
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
Co-authored-by: alafanechere <[email protected]>
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Co-authored-by: alafanechere <[email protected]>
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Co-authored-by: alafanechere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add publish action for airbyte-lib to release on pypi