Skip to content

🐛 Source Amazon Seller Partner: fix report decompression #32457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

artem1205
Copy link
Contributor

@artem1205 artem1205 commented Nov 13, 2023

What

Resolve https://github.com/airbytehq/alpha-beta-issues/issues/1512

How

incorrect header check

was probably caused by non-200 response.

  • use gzip instead of zlib.
  • add retry for report download request.

Recommended reading order

  1. streams.py

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 2:28pm

Copy link
Contributor

github-actions bot commented Nov 13, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205 artem1205 changed the title Source Amazon Seller Partner: add retry for empty/wrong report 🐛 Source Amazon Seller Partner: fix report decompression Nov 13, 2023
@artem1205 artem1205 marked this pull request as ready for review November 13, 2023 14:28
@artem1205 artem1205 self-assigned this Nov 13, 2023
@artem1205 artem1205 merged commit 9b6a1cc into master Nov 13, 2023
@artem1205 artem1205 deleted the artem1205/source-amazon-seller-partner-zlib-1512 branch November 13, 2023 15:38
@krisjan-oldekamp
Copy link
Contributor

@artem1205 For the report, I'm receiving this error now (Airbyte OSS / 0.50.30, connector version 1.6.2), probably related to this PR?

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/airbyte_cdk/sources/abstract_source.py", line 116, in read
    stream_is_available, reason = stream_instance.check_availability(logger, self)
  File "/usr/local/lib/python3.9/site-packages/airbyte_cdk/sources/streams/core.py", line 263, in check_availability
    return self.availability_strategy.check_availability(self, logger, source)
  File "/usr/local/lib/python3.9/site-packages/airbyte_cdk/sources/streams/http/availability_strategy.py", line 50, in check_availability
    get_first_record_for_slice(stream, stream_slice)
  File "/usr/local/lib/python3.9/site-packages/airbyte_cdk/sources/streams/utils/stream_helper.py", line 40, in get_first_record_for_slice
    return next(records_for_slice)
  File "/airbyte/integration_code/source_amazon_seller_partner/streams.py", line 345, in read_records
    yield from self.parse_response(response, stream_state, stream_slice)
  File "/airbyte/integration_code/source_amazon_seller_partner/streams.py", line 925, in parse_response
    document = self.decompress_report_document(
AttributeError: 'SellerAnalyticsSalesAndTrafficReports' object has no attribute 'decompress_report_document'```

@artem1205
Copy link
Contributor Author

@krisjan-oldekamp , agreed, will be fixed in #32505

@krisjan-oldekamp
Copy link
Contributor

@artem1205 I also encountered the same error for the Vendor Sales Report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-seller-partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants