-
Notifications
You must be signed in to change notification settings - Fork 4.5k
🐛 Source Amazon Seller Partner: mark "aws_secret_key" and "aws_access_key" as required #32259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
artem1205
merged 9 commits into
master
from
artem1205/source-amazon-seller-partner-32235
Nov 9, 2023
Merged
🐛 Source Amazon Seller Partner: mark "aws_secret_key" and "aws_access_key" as required #32259
artem1205
merged 9 commits into
master
from
artem1205/source-amazon-seller-partner-32235
Nov 9, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
This was
linked to
issues
Nov 8, 2023
…UCT_MARGIN_REPORT
…URE_PRODUCT_MARGIN_REPORT" This reverts commit 39e716c.
askarpets
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/amazon-seller-partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve
How
mark:
aws_secret_key
andaws_access_key
as requiredreplication_start_date
andreplication_end_date
as datetimeupdate schema for stream
Orders
Recommended reading order
spec.json
Orders.json
metadata.yaml
🚨 User Impact 🚨
no breaking changes
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.