Skip to content

🐛 Source Google Ads: add retry to handle InternalServerError for grpc internal lib #32001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

bazarnov
Copy link
Collaborator

What

Resolving: https://github.com/airbytehq/oncall/issues/3335

How

  • added InternalServerError to the list of errors to catch for backoff strategy.

🚨 User Impact 🚨

No impact is expected. Hotfix.

@bazarnov bazarnov self-assigned this Oct 31, 2023
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2023 2:40pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Oct 31, 2023
Copy link
Contributor

github-actions bot commented Oct 31, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@bazarnov bazarnov marked this pull request as ready for review October 31, 2023 13:59
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 31, 2023
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 31, 2023 14:01
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 31, 2023 14:13
@bazarnov bazarnov requested a review from davydov-d October 31, 2023 14:14
@bazarnov bazarnov merged commit e54c2cf into master Oct 31, 2023
@bazarnov bazarnov deleted the baz/google-ads/add-intenal-server-error-retry branch October 31, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads
Projects
No open projects
Status: In review (internal)
Development

Successfully merging this pull request may close these issues.

3 participants