airbyte-ci: disable gradle cache cleanup #31811
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
alafanechere
force-pushed
the
augustin/10-25-airbyte-ci_disable_gradle_cache_cleanup
branch
from
b9af29f to
3ea639e
Compare
| gradle_container = ( | ||
| gradle_container | ||
| # TODO: remove this once we finish the project to boost source-postgres CI performance. | ||
| .with_env_variable("CACHEBUSTER", hacks.get_cachebuster(self.context, self.logger)).with_exec( |
There was a problem hiding this comment.
Missing newline before .with_exec.
| # https://github.com/gradle/gradle/issues/7018#issuecomment-473817849 | ||
| # If we ever upgrade to Gradle 8 a different approach must be taken | ||
| # https://docs.gradle.org/current/userguide/directory_layout.html#dir:gradle_user_home:cache_cleanup | ||
| user_gradle_properties = "org.gradle.cache.cleanup=false" |
There was a problem hiding this comment.
We should, at some point NOT in the far future, do this upgrade.
In any case, I would prefer passing the property as a command-line argument inside DEFAULT_GRADLE_TASK_OPTIONS as -Dorg.gradle.cache.cleanup=false that way you know it's not going to be overwritten by rsync with any existing gradle.properties file in the cache volume. Alternatively, add it not in DEFAULT_GRADLE_TASK_OPTIONS but in _get_gradle_command.
| # Set the current working directory. | ||
| .with_workdir("/airbyte") | ||
| # TODO: remove this once we finish the project to boost source-postgres CI performance. | ||
| .with_env_variable("CACHEBUSTER", hacks.get_cachebuster(self.context, self.logger)) |
There was a problem hiding this comment.
I put this there so that two consecutive source-postgres builds on an unchanged master branch would not skip doing the dependency update. I have no problems moving this variable further down, I didn't think about this too much.
What
This relates to #31439
CACHEBUSTERwe've introduced to not cache CI step execution to get reproducible CI duration metrics remained a bit upstream in the gradle execution logic: we likely burst the layers that warm the gradle cache...