airbyte-ci: only set docker hub secrets on dagger client if they exist #31752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
erohmensing
commented
Oct 23, 2023
| @@ -90,10 +90,17 @@ async def run_connectors_pipelines( | |||
| # HACK: This is to get a long running dockerd service to be shared across all the connectors pipelines | |||
| # Using the "normal" service binding leads to restart of dockerd during pipeline run that can cause corrupted docker state | |||
| # See https://github.com/airbytehq/airbyte/issues/27233 | |||
| docker_hub_username_secret = dagger_client.set_secret("DOCKER_HUB_USERNAME", contexts[0].docker_hub_username) | |||
There was a problem hiding this comment.
The issue was that .docker_hub_username (and password) returned None, which dagger_client.set_secret was not a fan of
There was a problem hiding this comment.
Hence the error raised on L248 of these logs
bnchrch
approved these changes
Oct 23, 2023
| docker_hub_username = contexts[0].docker_hub_username | ||
| docker_hub_password = contexts[0].docker_hub_password | ||
|
|
||
| if docker_hub_username and docker_hub_password: |
There was a problem hiding this comment.
💅 could use a doc here as to why we do this. But thats an extreme nit
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
🚨 User Impact 🚨
None
Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest.0.0.1Dockerfilehas version0.0.1README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog with an entry for the initial version. See changelog exampledocs/integrations/README.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:generateScaffoldsthen checking in your changesUpdating the Python CDK
Airbyter
Before merging:
--use-local-cdk --name=source-<connector>as optionsairbyte-ci connectors --use-local-cdk --name=source-<connector> testAfter merging: