🚨 🚨 🐍 Source Google Ads: fix custom queries

[tolik0]

What

Resolved issues with schema creation for custom queries.
#30253

How

• Corrected array type handling in custom queries.
• Replaced protobuf_message in the Message type with a string representation, as it is unnecessary.

🚨 User Impact 🚨

This update introduces breaking changes. Users must refresh their schemas due to custom query schemas creation changes. For example, for field ad_group_ad.ad.final_urls from custom query type change from {"type": "string"} to {"type": ["null", "array"], "items": {"type": "string"}}. Breaking changes doc.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Sep 28, 2023 8:40am

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[airbyte-oss-build-runner]

source-google-ads test report (commit f8bea7f05a) - ✅

⏲️ Total pipeline duration: 07mn19s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

[davydov-d]

Can you please add more context here? Why are you removing protobuf_message from the code? Why is this a breaking change? If it is, we should bump major version and follow a breaking change release process

[tolik0]

Can you please add more context here? Why are you removing protobuf_message from the code? Why is this a breaking change? If it is, we should bump major version and follow a breaking change release process

@davydov-d I updated description and added migration guide.

[airbyte-oss-build-runner]

source-google-ads test report (commit e4eeaa2c6c) - ❌

⏲️ Total pipeline duration: 01mn22s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform linux/x86_64	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

[airbyte-oss-build-runner]

source-google-ads test report (commit 67f87f15aa) - ❌

⏲️ Total pipeline duration: 06mn36s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

[airbyte-oss-build-runner]

source-google-ads test report (commit d5e7f6b60e) - ✅

⏲️ Total pipeline duration: 08mn01s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-google-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

[clnoll]

LGTM once the breaking changes doc is approved!

[pedroslopez]

/approve-and-merge reason="release + skip stuck gradle check"

[octavia-approvington]

Enough! Let's do this