Skip to content

[Source-mysql] Increase INITIAL_CDC_WAITING_SECONDS for avoiding timeouts in integration tests. #29854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

prateekmukhedkar
Copy link
Contributor

@prateekmukhedkar prateekmukhedkar commented Aug 25, 2023

These tests were failing and after some investigation it points to timeouts waiting for Debezium to start so we are trying with increasing CDC Wait time in integration tests.

CdcBinlogsMySqlSourceDatatypeTest. testDataContent() CdcBinlogsMySqlSourceDatatypeTest. testDataTypes() CdcInitialSnapshotMySqlSourceDatatypeTest. testDataContent() CdcMySqlSourceAcceptanceTest. testEmptyStateIncrementalIdenticalToFullRefresh() CdcMySqlSourceAcceptanceTest. testIncrementalSyncShouldNotFailIfBinlogIsDeleted() CdcMySqlSslCaCertificateSourceAcceptanceTest. testEmptyStateIncrementalIdenticalToFullRefresh() CdcMySqlSslCaCertificateSourceAcceptanceTest. testIncrementalSyncShouldNotFailIfBinlogIsDeleted() CdcMySqlSslRequiredSourceAcceptanceTest. testEmptyStateIncrementalIdenticalToFullRefresh() CdcMySqlSslRequiredSourceAcceptanceTest. testIncrementalSyncShouldNotFailIfBinlogIsDeleted()

Do not run tests in parallel
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@github-actions
Copy link
Contributor

source-mysql test report (commit 6f9fc6debf) - ❌

⏲️ Total pipeline duration: 129mn54s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@prateekmukhedkar
Copy link
Contributor Author

So after removing numThreads the integ tests ran for 81 minutes and still failed (passing on local), so this is not a good change.

@github-actions
Copy link
Contributor

source-mysql-strict-encrypt test report (commit 6f9fc6debf) - ❌

⏲️ Total pipeline duration: 44mn46s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql-strict-encrypt docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql-strict-encrypt/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql-strict-encrypt test

@github-actions
Copy link
Contributor

source-mysql-strict-encrypt test report (commit 61ef467a12) - ❌

⏲️ Total pipeline duration: 44mn42s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql-strict-encrypt docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql-strict-encrypt/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql-strict-encrypt test

@prateekmukhedkar
Copy link
Contributor Author

Running notes - it seems testcontainers itself does not allow parallel tests at the moment? testcontainers/testcontainers-java#3220

@github-actions
Copy link
Contributor

source-mysql test report (commit 61ef467a12) - ❌

⏲️ Total pipeline duration: 83mn02s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@github-actions
Copy link
Contributor

source-postgres-strict-encrypt test report (commit 7e4df7db09) - ❌

⏲️ Total pipeline duration: 14mn26s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-postgres-strict-encrypt docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-postgres-strict-encrypt/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres-strict-encrypt test

@github-actions
Copy link
Contributor

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage 70.19% 🍏

@github-actions
Copy link
Contributor

source-postgres test report (commit 7e4df7db09) - ❌

⏲️ Total pipeline duration: 52mn11s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-postgres docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-postgres/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres test

@github-actions
Copy link
Contributor

source-mysql test report (commit 7e4df7db09) - ❌

⏲️ Total pipeline duration: 35mn56s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@github-actions
Copy link
Contributor

source-mysql test report (commit 1529d099a8) - ❌

⏲️ Total pipeline duration: 37mn37s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

Set INITIAL_CDC_WAITING_SECONDS to 30s
Revert temporary changes made to these test files
@github-actions
Copy link
Contributor

source-mysql test report (commit 2194cc5090) - ❌

⏲️ Total pipeline duration: 36mn36s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@github-actions
Copy link
Contributor

source-mysql test report (commit 52bc0d2954) - ❌

⏲️ Total pipeline duration: 36mn33s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@prateekmukhedkar prateekmukhedkar changed the title [Source-mysql] Do not run tests in parallel [Source-mysql] Increase INITIAL_CDC_WAITING_SECONDS for avoiding timeouts in integration tests. Aug 29, 2023
@github-actions
Copy link
Contributor

source-mysql test report (commit 20d8a5ae17) - ❌

⏲️ Total pipeline duration: 35mn43s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@prateekmukhedkar
Copy link
Contributor Author

@akashkulk running integration tests work locally with this change, CI is blocked due to #29463
./gradlew tasks :airbyte-integrations:connectors:source-mysql:integrationTest

@github-actions
Copy link
Contributor

source-mysql test report (commit 71d00db526) - ❌

⏲️ Total pipeline duration: 19mn16s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@akashkulk
Copy link
Contributor

Thanks! This fixes tests locally! BTW the timeout can be reduced as low as 10 seconds and still works

@prateekmukhedkar prateekmukhedkar enabled auto-merge (squash) September 6, 2023 21:18
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

source-mysql test report (commit f46c116c90) - ❌

⏲️ Total pipeline duration: 321mn43s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

auto-merge was automatically disabled September 8, 2023 18:10

Pull request was closed

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

source-mysql test report (commit 9bef73ca46) - ❌

⏲️ Total pipeline duration: 321mn10s

Step Result
Java Connector Unit Tests
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Java Connector Integration Tests
Acceptance tests
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants