Skip to content

✨ Destination Databricks Lakehouse : incremental-dedup sync #29510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shrodingers
Copy link
Contributor

@shrodingers shrodingers commented Aug 17, 2023

What

Allow the incremental-dedup sync with databricks connector, and adds an option to only normalize the first nested level of data

How

  • Added normalization models for databricks through dbt and macros (will only work with managed tables)

Recommended reading order

  1. dbt macros
  2. normalizations/transform_catalog
  3. databricks connector updates

🚨 User Impact 🚨

There will be impact if migrating to managed tables.

Otherwise, it just uses the raw data in managed tables and applying models on top of it, so breaking if changing the sync in destination.

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@shrodingers shrodingers marked this pull request as draft August 17, 2023 08:35
@shrodingers shrodingers marked this pull request as ready for review August 17, 2023 12:30
@evantahler
Copy link
Contributor

evantahler commented Aug 18, 2023

Thank you for all of this work @shrodingers, but I am going to close this PR. Airbyte is actively removing dbt from our codebase, and moving on to "Destinations V2" to handle Typing and Deduplicating data within columnar destinations.

The good news is that our new destinations core code is in Java, and much easier to use. The Snowflake and BigQuery destinations are already live with Destinations V2 you can try out today, and you can check out the code to see how they work. Are you interested in moving the Databricks destination to Destinations V2? The team is happy to provide some guidance in Slack or Github if you are.

More docs on Destinations V2:

@evantahler evantahler closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants