connectors-ci: per connector dockerd #28566
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
octavia-squidington-iii
added
connectors/source/openweather
and removed
area/connectors
alafanechere
force-pushed
the
augustin/connectors-ci/per-connector-dockerd
branch
from
692b84e to
a04352d
Compare
alafanechere
force-pushed
the
augustin/connectors-ci/per-connector-dockerd
branch
from
a04352d to
5d0d282
Compare
bnchrch
approved these changes
Jul 21, 2023
| dockerd = context.dockerd_service | ||
| docker_hostname = "global-docker-host" | ||
| dockerd_service = with_dockerd_service(context) | ||
| docker_hostname = f"{slugify(context.connector.technical_name)}-docker-host" |
|
Closing as unexpected Dagger / Docker errors were observed on the nightly build and #28000 is showing good progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #27867
#28000 is our best bet at reducing reliance on dockerd and its potential over caching issues. But it's currently blocked because I'm looking for advices from the Dagger team for the dagger-in-dagger usecase.
This PR is an alternative approach to try to increase isolation in CAT run:
We originally had one global docker daemon shared accross containers and we suspect it to be the root cause dubious connector command output in CAT causing transient CAT failures.
Having a per-connector dockerd was not the recommended approach by the Dagger team as it creates a lot of overhead and services to manage for the engine. But we're trying this approach again to see if the original issues we had persist / have been solved in the latest Dagger version.
Tests
A "nightly build" on all GA connectors is running here