Stop publishing java connectors on merge to master #28344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
pedroslopez
commented
Jul 15, 2023
Comment on lines
+106
to
+107
| if modified: | ||
| selected_connectors_and_files = modified_connectors_and_files |
There was a problem hiding this comment.
Moved this to be before the other filters so they can be applied together
Comment on lines
-315
to
-317
| if ctx.obj["modified"]: | ||
| selected_connectors_and_files = get_modified_connectors(get_modified_metadata_files(ctx.obj["modified_files"])) | ||
| selected_connectors_names = [connector.technical_name for connector in selected_connectors_and_files.keys()] |
There was a problem hiding this comment.
Modified connectors were already being filtered out in the previous step, so the selected_connectors_and_files ctx already does this.
This was overwriting the other filters in the publish step
| @@ -39,7 +39,7 @@ jobs: | |||
| metadata_service_gcs_credentials: ${{ secrets.METADATA_SERVICE_PROD_GCS_CREDENTIALS }} | |||
| slack_webhook_url: ${{ secrets.PUBLISH_ON_MERGE_SLACK_WEBHOOK }} | |||
| spec_cache_gcs_credentials: ${{ secrets.SPEC_CACHE_SERVICE_ACCOUNT_KEY_PUBLISH }} | |||
| subcommand: "connectors --concurrency=1 --execute-timeout=3600 --modified publish --main-release" | |||
| subcommand: "connectors --concurrency=1 --execute-timeout=3600 --modified --language=python --language=low-code publish --main-release" | |||
There was a problem hiding this comment.
Skip java connectors by specifying we only want python and low-code connectors
Coverage report for source-postgres
|
pedroslopez
changed the title
bnchrch
approved these changes
Jul 15, 2023
efimmatytsin
pushed a commit
to scentbird/airbyte
that referenced
this pull request
Jul 27, 2023
* process language after modified flag * modify some connectors * empty commit * another bump * modified connectors are already filtered * change some connectors * change some connectors again * revert to master version * nit * filter for python/lowcode connectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes our "publish on merge" workfow to ignore java connectors
Example run with languages specified for change on faker + postgres (
--modified --language=python):https://github.com/airbytehq/airbyte/actions/runs/5559625325/jobs/10155926192#step:5:535
Example run with no languages specified for change on faker + postgres (
--modified)https://github.com/airbytehq/airbyte/actions/runs/5559622521/jobs/10155920377#step:5:532
How
--modifiedargpythonandlow-codelanguages so java is excluded.