-
Notifications
You must be signed in to change notification settings - Fork 4.5k
🎉 Source Google Ads: add new stream Campaign Budget
#28078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Google Ads: add new stream Campaign Budget
#28078
Conversation
…ds-new-stream-campaign-budget
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
…ds-new-stream-campaign-budget
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-google-ads docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-google-ads test
…ds-new-stream-campaign-budget
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-google-ads docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-google-ads test
What
Resolving:
How
CampaignBudget
expected records
for the new streamNOTES:
The following
SEGMENTS
are not included in the stream:since they have conflicts with certain AVG aggregated
METRICS
like:They could be fetched without avg aggregated metrics (the general metrics only)
🚨 User Impact 🚨
No impact is expected - not a breaking change