-
Notifications
You must be signed in to change notification settings - Fork 4.6k
✨ Source auth0: add new streams Organizations
, OrganizationMembers
, OrganizationMemberRoles
#27500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
unit tests execution
|
integrations tests execution
|
Hi @marcosmarxm, tagging you because you reviewed the clients stream in #25985 |
@vasilisgav we're going to take a look later this week sorry the missing return to you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you bump the version in the metadata.yaml file?
...yte-integrations/connectors/source-auth0/source_auth0/schemas/organization_member_roles.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I have submitted some questions and changes to make!
airbyte-integrations/connectors/source-auth0/source_auth0/schemas/clients.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-auth0/source_auth0/schemas/clients.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-auth0/source_auth0/schemas/users.json
Outdated
Show resolved
Hide resolved
@vasilisgav can you run the python format command?
|
Hi @sajarin it is actually failing
But I believe I didn't introduce this error. It must have already been there. Regardless, can you help me tackle this? Cheers! |
You must be in the root folder of the project not inside |
Actually I am indeed in the root directory
May be something with python virtual env and gradlew not working so well together |
Thank you Both, @marcosmarxm and @sajarin I was able to fix the gradle issue Here is gradlew running successfully:
Can you have another look please? |
Thanks @vasilisgav, we just need to set up our integration account properly so that the tests pass on our end. Hope to get this merged soon! |
Hi @sajarin, @marcosmarxm , any update? I would like to contribute on additional streams, and I am waiting for the merge first. |
hey @vasilisgav sorry for the delay here. The connector is still broken on our integration account. We're missing some records on our sandbox account as well for the organization members, once that's updated we can proceed with the merge. Is this currently blocking you from creating new PRs? |
@sajarin now that you mention it, not really blocking, I might hit some conflicts though, will solve them when the time comes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @vasilisgav I ran tests and made quick adjustments in #29001 and will get your contribution merged there together with my changes.
Thank you @marcosmarxm ! |
What
Add support for organization related streams in auth0 source connector issue #27499
How
Connector in place had all the scaffolding ready, so adding a new stream was simple enough
🚨 User Impact 🚨
No breaking changes
Pre-merge Actions
New Stream for source Connector auth0
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.0.2.0
Dockerfile
has version0.0.1
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog with an entry for the initial version. See changelog exampledocs/integrations/README.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes