-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix issue in streaming JDBC database #27212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test connector=connectors/source-postgres
Build FailedTest summary info:
|
/test connector=connectors/source-mysql
Build FailedTest summary info:
|
/test connector=connectors/source-mssql
Build PassedTest summary info:
|
/test connector=connectors/source-snowflake
Build FailedTest summary info:
|
/test connector=connectors/source-postgres
Build FailedTest summary info:
|
The runs that would have succeeded are not going to impact this change. |
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/destination-redshift/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ✅ |
Build destination-redshift docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Build airbyte/normalization-redshift:dev | ✅ |
Integration tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-redshift test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-tidb/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ✅ |
Build source-tidb docker image for platform linux/x86_64 | ✅ |
Unit tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-tidb test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/destination-oracle/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-oracle test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/destination-teradata/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-teradata test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/destination-mysql-strict-encrypt/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-mysql-strict-encrypt test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-oracle/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-oracle test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/destination-clickhouse/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-clickhouse test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/destination-clickhouse-strict-encrypt/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-clickhouse-strict-encrypt test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-cockroachdb/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-cockroachdb test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-postgres/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-postgres test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-oracle-strict-encrypt/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-oracle-strict-encrypt test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/destination-e2e-test/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-e2e-test test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-postgres-strict-encrypt/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-postgres-strict-encrypt test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in team meeting, this change will have no impact on those syncs that would have normally completed.
Coverage report for source-postgres
|
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/destination-mariadb-columnstore/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ✅ |
Build destination-mariadb-columnstore docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-mariadb-columnstore test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/destination-rockset/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ❌ |
Build connector tar | ✅ |
Build destination-rockset docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-rockset test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/destination-pubsub/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ✅ |
Build connector tar | ✅ |
Build destination-pubsub docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-pubsub test
Coverage report for source-postgres
|
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-postgres-strict-encrypt/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ✅ |
Build connector tar | ✅ |
Build source-postgres-strict-encrypt docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-postgres-strict-encrypt test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-tidb/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ✅ |
QA checks | ✅ |
Build connector tar | ✅ |
Build source-tidb docker image for platform linux/x86_64 | ✅ |
Unit tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-tidb test
Coverage report for source-postgres
|
/approve-and-merge reason="Small change, want to isolate from other failing tests" |
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-postgres-strict-encrypt/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ❌ |
Build connector tar | ✅ |
Build source-postgres-strict-encrypt docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-postgres-strict-encrypt test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-tidb/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ❌ |
Build connector tar | ✅ |
Build source-tidb docker image for platform linux/x86_64 | ✅ |
Unit tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-tidb test
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-oracle/metadata.yaml | ✅ |
Connector version semver check. | ✅ |
Connector version increment check. | ❌ |
QA checks | ❌ |
Build connector tar | ✅ |
Build source-oracle docker image for platform linux/x86_64 | ✅ |
Unit tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-oracle test
Closes #26986
Partially reverts a change in #20888
The issue here is that :
XminStateIterator
emits state because the underlying iterator returns false instead of throwing an exception.[onClose](https://github.com/airbytehq/airbyte/blob/master/airbyte-db/db-lib/src/main/java/io/airbyte/db/jdbc/StreamingJdbcDatabase.java#L72)()
method does indeed run with this change. So it's not clear if this fix was only tested against a particular DB (Redshift maybe?)Testing methodology :
I have already built an xmin image
2.0.33-dev.f995e7a36e
and updated it on LD based on the following PR :#26723 and verified that it fixes the given issue