Skip to content

Fix issue in streaming JDBC database #27212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 20, 2023
Merged

Fix issue in streaming JDBC database #27212

merged 18 commits into from
Jun 20, 2023

Conversation

akashkulk
Copy link
Contributor

@akashkulk akashkulk commented Jun 9, 2023

Closes #26986

Partially reverts a change in #20888

The issue here is that :

  • If there is a exception caught, the JDBC streaming iterator silently catches the exception and the parent XminStateIterator emits state because the underlying iterator returns false instead of throwing an exception.
  • I was not able to reproduce the issue that the comments says : "throwing an exception in tryAdvance() method lead to the endless loop in Spliterator and stream will never close". I've verified that the [onClose](https://github.com/airbytehq/airbyte/blob/master/airbyte-db/db-lib/src/main/java/io/airbyte/db/jdbc/StreamingJdbcDatabase.java#L72)() method does indeed run with this change. So it's not clear if this fix was only tested against a particular DB (Redshift maybe?)

Testing methodology :

  1. Create a driver class (similar to what @subodh1810 did in this PR : https://github.com/airbytehq/airbyte/pull/21398/files) with the configs for a sample DB. I used the configs and catalog associated with my test DB, set to xmin replication here :
  2. Attach a breakpoint to the start of when the connector begins syncing data.
  3. Disconnect the DB
  4. Assert that no state is emitted.

I have already built an xmin image 2.0.33-dev.f995e7a36e and updated it on LD based on the following PR :#26723 and verified that it fixes the given issue

@akashkulk
Copy link
Contributor Author

akashkulk commented Jun 9, 2023

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/5223925793
❌ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/5223925793
🐛 https://gradle.com/s/3ot2okvv5l3ck

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestConnection::test_check[inputs1] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_core.py::TestDiscovery::test_discover[inputs1] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs1-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs1-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs1] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs1]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs1] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_core.py::TestBasicRead::test_read[inputs1] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
======== 4 failed, 46 passed, 5 skipped, 20 errors in 304.41s (0:05:04) ========

@akashkulk
Copy link
Contributor Author

akashkulk commented Jun 9, 2023

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/5223926794
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/5223926794
🐛 https://gradle.com/s/rkac6uyua7vmc

Build Failed

Test summary info:

Could not find result summary

@akashkulk
Copy link
Contributor Author

akashkulk commented Jun 9, 2023

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/5223927893
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/5223927893
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================= 22 passed, 6 skipped, 30 warnings in 22.11s ==================

@akashkulk
Copy link
Contributor Author

akashkulk commented Jun 9, 2023

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/5223928835
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/5223928835
🐛 https://gradle.com/s/5pkcubfi2npiy

Build Failed

Test summary info:

Could not find result summary

@akashkulk
Copy link
Contributor Author

akashkulk commented Jun 13, 2023

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/5258608078
❌ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/5258608078
🐛 https://gradle.com/s/gwdvgjzcsepu6

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestConnection::test_check[inputs1] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_core.py::TestDiscovery::test_discover[inputs1] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs1-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs1-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_streams_has_sync_modes[inputs1] - doc...
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
ERROR test_core.py::TestDiscovery::test_additional_properties_is_true[inputs1]
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - doc...
ERROR test_core.py::TestDiscovery::test_backward_compatibility[inputs1] - doc...
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_core.py::TestBasicRead::test_read[inputs1] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
======== 4 failed, 46 passed, 5 skipped, 20 errors in 301.73s (0:05:01) ========

@akashkulk akashkulk marked this pull request as ready for review June 13, 2023 17:30
@prateekmukhedkar
Copy link
Contributor

prateekmukhedkar commented Jun 14, 2023

The runs that would have succeeded are not going to impact this change.
Hypotheses to mitigate for the risk of releasing the change that reverts a previous fix - watchForOrphanThreads in IntegrationRunner should catch any infinite loops

@octavia-squidington-iii
Copy link
Collaborator

destination-redshift test report (commit 7937029185) - ❌

⏲️ Total pipeline duration: 1874 seconds

Step Result
Validate airbyte-integrations/connectors/destination-redshift/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar
Build destination-redshift docker image for platform linux/x86_64
Unit tests
Build airbyte/normalization-redshift:dev
Integration tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-redshift test

@octavia-squidington-iii
Copy link
Collaborator

source-tidb test report (commit 7937029185) - ❌

⏲️ Total pipeline duration: 1520 seconds

Step Result
Validate airbyte-integrations/connectors/source-tidb/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar
Build source-tidb docker image for platform linux/x86_64
Unit tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tidb test

@octavia-squidington-iii
Copy link
Collaborator

destination-oracle test report (commit 7937029185) - ❌

⏲️ Total pipeline duration: 6 seconds

Step Result
Validate airbyte-integrations/connectors/destination-oracle/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-oracle test

@octavia-squidington-iii
Copy link
Collaborator

destination-teradata test report (commit 7937029185) - ❌

⏲️ Total pipeline duration: 7 seconds

Step Result
Validate airbyte-integrations/connectors/destination-teradata/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-teradata test

@octavia-squidington-iii
Copy link
Collaborator

destination-mysql-strict-encrypt test report (commit 7937029185) - ❌

⏲️ Total pipeline duration: 4 seconds

Step Result
Validate airbyte-integrations/connectors/destination-mysql-strict-encrypt/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-mysql-strict-encrypt test

@octavia-squidington-iii
Copy link
Collaborator

source-oracle test report (commit 7937029185) - ❌

⏲️ Total pipeline duration: 5 seconds

Step Result
Validate airbyte-integrations/connectors/source-oracle/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-oracle test

@octavia-squidington-iii
Copy link
Collaborator

destination-clickhouse test report (commit 7937029185) - ❌

⏲️ Total pipeline duration: 5 seconds

Step Result
Validate airbyte-integrations/connectors/destination-clickhouse/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-clickhouse test

@octavia-squidington-iii
Copy link
Collaborator

destination-clickhouse-strict-encrypt test report (commit 7937029185) - ❌

⏲️ Total pipeline duration: 5 seconds

Step Result
Validate airbyte-integrations/connectors/destination-clickhouse-strict-encrypt/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-clickhouse-strict-encrypt test

@octavia-squidington-iii
Copy link
Collaborator

source-cockroachdb test report (commit 7937029185) - ❌

⏲️ Total pipeline duration: 5 seconds

Step Result
Validate airbyte-integrations/connectors/source-cockroachdb/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-cockroachdb test

@octavia-squidington-iii
Copy link
Collaborator

source-postgres test report (commit 7937029185) - ❌

⏲️ Total pipeline duration: 8 seconds

Step Result
Validate airbyte-integrations/connectors/source-postgres/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres test

@octavia-squidington-iii
Copy link
Collaborator

source-oracle-strict-encrypt test report (commit 7937029185) - ❌

⏲️ Total pipeline duration: 4 seconds

Step Result
Validate airbyte-integrations/connectors/source-oracle-strict-encrypt/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-oracle-strict-encrypt test

@octavia-squidington-iii
Copy link
Collaborator

destination-e2e-test test report (commit 7937029185) - ❌

⏲️ Total pipeline duration: 4 seconds

Step Result
Validate airbyte-integrations/connectors/destination-e2e-test/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-e2e-test test

@octavia-squidington-iii
Copy link
Collaborator

source-postgres-strict-encrypt test report (commit 7937029185) - ❌

⏲️ Total pipeline duration: 4 seconds

Step Result
Validate airbyte-integrations/connectors/source-postgres-strict-encrypt/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres-strict-encrypt test

Copy link
Contributor

@prateekmukhedkar prateekmukhedkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in team meeting, this change will have no impact on those syncs that would have normally completed.

@github-actions
Copy link
Contributor

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage 65.95% 🍏

@octavia-squidington-iii
Copy link
Collaborator

destination-mariadb-columnstore test report (commit 633efb530a) - ❌

⏲️ Total pipeline duration: 5677 seconds

Step Result
Validate airbyte-integrations/connectors/destination-mariadb-columnstore/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar
Build destination-mariadb-columnstore docker image for platform linux/x86_64
Unit tests
Integration tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-mariadb-columnstore test

@octavia-squidington-iii
Copy link
Collaborator

destination-rockset test report (commit 633efb530a) - ❌

⏲️ Total pipeline duration: 639 seconds

Step Result
Validate airbyte-integrations/connectors/destination-rockset/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar
Build destination-rockset docker image for platform linux/x86_64
Unit tests
Integration tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-rockset test

@octavia-squidington-iii
Copy link
Collaborator

destination-pubsub test report (commit 633efb530a) - ❌

⏲️ Total pipeline duration: 1073 seconds

Step Result
Validate airbyte-integrations/connectors/destination-pubsub/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar
Build destination-pubsub docker image for platform linux/x86_64
Unit tests
Integration tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-pubsub test

@github-actions
Copy link
Contributor

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage 65.95% 🍏

@octavia-squidington-iii
Copy link
Collaborator

source-postgres-strict-encrypt test report (commit d75b4777b4) - ✅

⏲️ Total pipeline duration: 722 seconds

Step Result
Validate airbyte-integrations/connectors/source-postgres-strict-encrypt/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar
Build source-postgres-strict-encrypt docker image for platform linux/x86_64
Unit tests
Integration tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres-strict-encrypt test

@octavia-squidington-iii
Copy link
Collaborator

source-tidb test report (commit d75b4777b4) - ❌

⏲️ Total pipeline duration: 1532 seconds

Step Result
Validate airbyte-integrations/connectors/source-tidb/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar
Build source-tidb docker image for platform linux/x86_64
Unit tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tidb test

@github-actions
Copy link
Contributor

Coverage report for source-postgres

File Coverage [85.87%] 🍏
PostgresSource.java 85.87% 🍏
Total Project Coverage 65.95% 🍏

@akashkulk
Copy link
Contributor Author

/approve-and-merge reason="Small change, want to isolate from other failing tests"

@octavia-approvington
Copy link
Contributor

Lets merge it
sheep thumbs up

@octavia-approvington octavia-approvington merged commit 2f80744 into master Jun 20, 2023
@octavia-approvington octavia-approvington deleted the leak_revert branch June 20, 2023 17:08
@octavia-squidington-iii
Copy link
Collaborator

source-postgres-strict-encrypt test report (commit 3784330e11) - ❌

⏲️ Total pipeline duration: 724 seconds

Step Result
Validate airbyte-integrations/connectors/source-postgres-strict-encrypt/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar
Build source-postgres-strict-encrypt docker image for platform linux/x86_64
Unit tests
Integration tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres-strict-encrypt test

@octavia-squidington-iii
Copy link
Collaborator

source-tidb test report (commit 3784330e11) - ❌

⏲️ Total pipeline duration: 1531 seconds

Step Result
Validate airbyte-integrations/connectors/source-tidb/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar
Build source-tidb docker image for platform linux/x86_64
Unit tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tidb test

@octavia-squidington-iii
Copy link
Collaborator

source-oracle test report (commit 3784330e11) - ❌

⏲️ Total pipeline duration: 189 seconds

Step Result
Validate airbyte-integrations/connectors/source-oracle/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Build connector tar
Build source-oracle docker image for platform linux/x86_64
Unit tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-oracle test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xmin saving intermediate stream state after a failed connection attempt
6 participants