🐛 Source Dynamodb: Fix missing scan permissions

[itaseskii]

What

Closes #25718

How

Adding a new configuration property which allows you to opt-in for ignoring tables that are missing read permissions

Recommended reading order

1. x.java
2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Connector version is set to 0.0.1
  • Dockerfile has version 0.0.1
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
  • docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.

Connector Generator

• Issue acceptance criteria met
• PR name follows PR naming conventions
• If adding a new generator, add it to the list of scaffold modules being tested
• The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
• Documentation which references the generator is updated as needed

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
• You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[murat-cetinkaya]

Does anyone know what this PR is waiting for? 🤔

[marcosmarxm]

The CI for this connector is not working right now. We must fix it first to run tests for this change.

[murat-cetinkaya]

@marcosmarxm is the CI still broken? Would it help if I submit a support ticket?

[murat-cetinkaya]

🙄

[marcosmarxm]

Sorry for the long delay in getting this reviewed and merged. Our team is currently finishing the August Hackathon review contributions over the next two weeks, and after that, we will return to the community backlog.

[marcosmarxm]

Hello @itaseskii thanks for the contribution. The current acceptance tests are failing but because of another problem. This week Airbyte codebase is freeze because of Thanksgiving but I'll start the review for your contribution to next week have it done. Thanks for the patience.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2024 1:32pm

[errorhandler]

Is there anything I can do to help here to get this merged? I've worked around this issue for now with a wide access policy but that will rapidly become a blocker to our continued use of Airbyte.

[anchitagarwal]

This issue is also causing a blocker for us in adopting Airbyte across multiple teams. Teams don't want to grant Scan access to tables they don't want to read. Hoping to get a resolution here.

[marcosmarxm]

Folks sorry this is stale for a long time. I'm organizing all contribution backlog and hope to get this in priority asap. The problem we can have it is... the destination CDK changed a lot and probably need a lot of refactor. If you want to help please reach me out in Slack.

[ayanguas]

I am testing the integration and it keeps trying to scan all tables. How can I set up to scan only those that have read permissions? In browser Airbyte open source version I can't see the option to ignore it.

[marcosmarxm]

@ayanguas check if you're using latest version of the connector and if can see a boolean toggle button for ignore_missing_read_permissions_tables

[ayanguas]

@marcosmarxm i'm using v0.2.3 version. I attach an image to show you what I get. In the optional fields only appears DynamoDB Endpoint, DynamoDB Region and Reserved Attribute Names. The toggle button to ignore tables that do not have permissions does not appear.

[marcosmarxm]

This is not the latest version of the connector. The latest version is 0.3.2