Skip to content

🎉 Source Amazon Seller Partner - Implement reportOptions for all missing reports #23606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 6, 2023
Merged

🎉 Source Amazon Seller Partner - Implement reportOptions for all missing reports #23606

merged 5 commits into from
Mar 6, 2023

Conversation

animer3009
Copy link
Contributor

@animer3009 animer3009 commented Mar 1, 2023 •
edited
Loading

What

Implement reportOptions for all missing reports and refactor

How

With changing Amazon Seller Partner Source connector

Issue: #23604

Terminal Saved Build Output.txt
Terminal Saved Integration Output.txt
Terminal Saved unit_test Output.txt

@animer3009
Copy link
Contributor Author

animer3009 commented Mar 1, 2023 •
edited
Loading

@lazebnyi @bazarnov @davydov-d @sajarin
Guys please review my changes to merge.

@animer3009 animer3009 changed the title Source Amazon Seller Partner - Implement reportOptions for all missing reports 🎉 Source Amazon Seller Partner - Implement reportOptions for all missing reports Mar 1, 2023
@lazebnyi lazebnyi requested review from davydov-d and lazebnyi March 2, 2023 09:52
@davydov-d
Copy link
Collaborator

davydov-d commented Mar 2, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-amazon-seller-partner

🕑 connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/4315269318
✅ connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/4315269318
Python tests coverage:

Name                                        Stmts   Miss  Cover
---------------------------------------------------------------
source_amazon_seller_partner/spec.py           23      0   100%
source_amazon_seller_partner/__init__.py        2      0   100%
source_amazon_seller_partner/constants.py      37      1    97%
source_amazon_seller_partner/source.py         51     12    76%
source_amazon_seller_partner/streams.py       571    242    58%
source_amazon_seller_partner/auth.py           61     36    41%
---------------------------------------------------------------
TOTAL                                         745    291    61%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 1189.37s (0:19:49) ==================

davydov-d
davydov-d reviewed Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@davydov-d davydov-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@animer3009 thanks for your contribution! I have one minor comment, otherwise it looks good. We should be good to proceed when the tests pass

@animer3009 @davydov-d
Update airbyte-integrations/connectors/source-amazon-seller-partner/s…
3e16e66 
…ource_amazon_seller_partner/streams.py

Co-authored-by: Denys Davydov <[email protected]>
@animer3009
Copy link
Contributor Author

Thank you @davydov-d .
I made commit of the change.

@davydov-d
Copy link
Collaborator

davydov-d commented Mar 3, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-amazon-seller-partner

🕑 Publishing the following connectors:
connectors/source-amazon-seller-partner
https://github.com/airbytehq/airbyte/actions/runs/4322458361


Connector Did it publish? Were definitions generated?
connectors/source-amazon-seller-partner ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@animer3009
Copy link
Contributor Author

@davydov-d @lazebnyi it need some action from me?

@davydov-d
Copy link
Collaborator

@animer3009 no. We have some issues running Github workflows against contributors PRs. I'll merge this PR once we have this issue resolved and the checks go green

@davydov-d davydov-d merged commit 95f1989 into airbytehq:master Mar 6, 2023
@animer3009 animer3009 deleted the amazon_sp_implement_options branch March 7, 2023 03:24
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
@animer3009 @davydov-d
@octavia-squidington-iii @danielduckworth
🎉 Source Amazon Seller Partner - Implement reportOptions for all miss…
abdab99 
…ing reports (airbytehq#23606)

* amazon sp implement reportOptions and refactor

* amazon sp bump version

* Update airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py

Co-authored-by: Denys Davydov <[email protected]>

* auto-bump connector version

---------

Co-authored-by: Denys Davydov <[email protected]>
Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davydov-d davydov-d davydov-d approved these changes

@lazebnyi lazebnyi Awaiting requested review from lazebnyi

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/amazon-seller-partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@animer3009 @davydov-d @octavia-squidington-iii