Skip to content

Add troubleshooting in local development #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hillairet
Copy link

What

Fix a couple of typos and add troubleshooting section in developing locally page to solve an issue I encountered.

How

The Java home folder needs to be explicitly defined.
This is a documentation update so I haven't gone through the checklist below.

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. test.java
  2. component.ts
  3. the rest

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! One question but LGTM otherwise.


For example:
```
env JAVA_HOME=/usr/lib/jvm/java-15-openjdk ./gradlew :airbyte-integrations:connectors:your-connector-dir:build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this point to Java 14?


For example:
```
env JAVA_HOME=/usr/lib/jvm/java-15-openjdk ./gradlew :airbyte-integrations:connectors:your-connector-dir:build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
env JAVA_HOME=/usr/lib/jvm/java-15-openjdk ./gradlew :airbyte-integrations:connectors:your-connector-dir:build
env JAVA_HOME=/usr/lib/jvm/java-14-openjdk ./gradlew :airbyte-integrations:connectors:your-connector-dir:build

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I think I have java 15 on my machine and that's where I needed this command. It seems to work fine with 15.

@sherifnada sherifnada merged commit b3fbc02 into airbytehq:master Mar 10, 2021
davydov-d added a commit that referenced this pull request Jun 26, 2023
davydov-d added a commit that referenced this pull request Jun 26, 2023
davydov-d added a commit that referenced this pull request Jun 27, 2023
davydov-d added a commit that referenced this pull request Jun 27, 2023
davydov-d added a commit that referenced this pull request Jun 27, 2023
davydov-d added a commit that referenced this pull request Jun 29, 2023
* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds

* #2344 source google ads: refactor date slicing

* #2344 source google ads: upd changelog

* #2344 review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants